Bug#839218: nama: FTBFS: Failed 1/7 test programs. 0/91 subtests failed.Bad plan. You planned 126 tests but ran 57.

Niko Tyni ntyni at debian.org
Wed Mar 22 19:53:01 UTC 2017


On Tue, Mar 21, 2017 at 04:05:43PM +0100, Balint Reczey wrote:

> It looks like not all regression are fixed after the re-implementation
> and the one affecting nama is one of them.

Some effort on a reduced test case would have been appreciated; the nama
code base is rather big.

While I haven't made it to the bottom of this yet, I note that there's
this code in lib/Audio/Nama/Effect.pm:

                my $perl_version = $^V;
                my ($minor_version) = $perl_version =~ /^v5\.(\d+)/;
                my @new_list = grep  { $_ ne $id  } @ops_list;
                #say "new_list: @new_list";
                if ($minor_version <= 14) 
                     {    $track->{ops}   = [ @new_list  ] }
                else { @{ $track->{ops} } =   @new_list    }

and if I patch that to take the <= 14 code path, the segfault goes away
here and all tests pass. What's the history behind this version check?
-- 
Niko Tyni   ntyni at debian.org




More information about the Perl-maintainers mailing list