[Piuparts-commits] rev 351 - piatti/home/piupartsm piatti/home/piupartsm/bin piatti/home/piupartss/bin trunk

[Holger Levsen]

Author: holger
Date: 2009-04-17 21:08:51 +0000 (Fri, 17 Apr 2009)
New Revision: 351

Added:
   piatti/home/piupartsm/bin/detect_tmp_cruft
Modified:
   piatti/home/piupartsm/crontab
   piatti/home/piupartss/bin/detect_leftover_processes
   trunk/TODO
   trunk/piuparts-report.py
Log:
add cronjob to monitor for tmp cruft, plus some minor fixes

Copied: piatti/home/piupartsm/bin/detect_tmp_cruft (from rev 322, piatti/home/piupartsm/bin/detect_stale_mounts)
===================================================================
--- piatti/home/piupartsm/bin/detect_tmp_cruft	                        (rev 0)
+++ piatti/home/piupartsm/bin/detect_tmp_cruft	2009-04-17 21:08:51 UTC (rev 351)
@@ -0,0 +1,28 @@
+#!/bin/sh
+
+# Copyright 2009 Holger Levsen (holger at layer-acht.org)
+# 
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by the
+# Free Software Foundation; either version 2 of the License, or (at your
+# option) any later version.
+# 
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General
+# Public License for more details.
+# 
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, write to the Free Software Foundation, Inc.,
+# 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+
+LS_TMP=$(ls --color=never -l /org/piuparts.debian.org/tmp)
+if [ "$(LS_TMP | wc -l)" -gt 12 ] ; then 
+	echo "More than ten directories in /org/piuparts.debian.org/tmp detected!"
+	echo
+	echo $LS_TMP
+	echo
+	echo "One is normal for piuparts operation, more is not."
+	echo "Please investigate and cleanup."
+fi
+rm $FILE


Property changes on: piatti/home/piupartsm/bin/detect_tmp_cruft
___________________________________________________________________
Added: svn:executable
   + *
Added: svn:mergeinfo
   + 

Modified: piatti/home/piupartsm/crontab
===================================================================
--- piatti/home/piupartsm/crontab	2009-04-17 20:55:24 UTC (rev 350)
+++ piatti/home/piupartsm/crontab	2009-04-17 21:08:51 UTC (rev 351)
@@ -24,5 +24,6 @@
 # monitor for problems once a day
 #
 42 7 * * * /home/piupartsm/bin/detect_stale_mounts
+43 7 * * * /home/piupartsm/bin/detect_tmp_cruft
 44 7 * * * /home/piupartsm/bin/detect_network_issues
 45 7 * * * /home/piupartsm/bin/report_untestable_packages

Modified: piatti/home/piupartss/bin/detect_leftover_processes
===================================================================
--- piatti/home/piupartss/bin/detect_leftover_processes	2009-04-17 20:55:24 UTC (rev 350)
+++ piatti/home/piupartss/bin/detect_leftover_processes	2009-04-17 21:08:51 UTC (rev 351)
@@ -19,7 +19,7 @@
 MONITORDIR=/org/piuparts.debian.org/master/monitor-slave
 LOCKFILE="$MONITORDIR/leftover_processes"
 
-OUTPUT=$(sudo ls /proc/*/root -lad 2>/dev/null|grep "/org/piuparts.debian.org/tmp" | grep "(deleted)")
+OUTPUT=$(sudo ls  --color=never -lad /proc/*/root 2>/dev/null|grep "/org/piuparts.debian.org/tmp" | grep "(deleted)")
 if [ "$OUTPUT" != "" ] && [ "$(cat $LOCKFILE)" != "$OUTPUT" ] ; then
 	echo "Found processes running with a deleted chroot in /org/piuparts.debian.org/tmp/"
 	echo "This is usually because of 'FAIL: Processes are running inside chroot' which usually"

Modified: trunk/TODO
===================================================================
--- trunk/TODO	2009-04-17 20:55:24 UTC (rev 350)
+++ trunk/TODO	2009-04-17 21:08:51 UTC (rev 351)
@@ -11,7 +11,6 @@
 -- slave
 --- mention distro when sending logs
 --- slave_run: cleanup stale proc mountpoints
---- cronjob: warn about 10 or more tmp filesystems...
 --- slave_stop script - unneeded with patch for #523958
 - then R
 - probably include patch for #523950

Modified: trunk/piuparts-report.py
===================================================================
--- trunk/piuparts-report.py	2009-04-17 20:55:24 UTC (rev 350)
+++ trunk/piuparts-report.py	2009-04-17 21:08:51 UTC (rev 351)
@@ -615,7 +615,7 @@
     def link_to_state_page(self, section, package_name, state):
         link = "<a href=\"/%s/%s\">%s</a>" % (
                 section,
-                state+".html"+"#"+package_name,
+                "state-"+state+".html"+"#"+package_name,
                 state)
         return link