[Piuparts-commits] rev 464 - piatti/home/piupartsm/bin

[Holger Levsen]

Author: holger
Date: 2009-08-08 08:56:14 +0000 (Sat, 08 Aug 2009)
New Revision: 464

Modified:
   piatti/home/piupartsm/bin/detect_well_known_errors
Log:
correctly list logs with undetected errors

Modified: piatti/home/piupartsm/bin/detect_well_known_errors
===================================================================
--- piatti/home/piupartsm/bin/detect_well_known_errors	2009-08-08 08:26:19 UTC (rev 463)
+++ piatti/home/piupartsm/bin/detect_well_known_errors	2009-08-08 08:56:14 UTC (rev 464)
@@ -76,21 +76,18 @@
 for SECTION in $SECTIONS ; do 
 	cd $MASTER/$SECTION
 	find fail -name "*.log" > $LOGS
-	for LOG in $(cat ${KNOWNLOGS[$NR]}) ; do
-		grep -v $LOG $LOGS > $UNKNOWNLOGS
-		cp $UNKNOWNLOGS $LOGS
-	done
-	if [ -s $LOGS ] ; then
+	grep -v -f ${KNOWNLOGS[$NR]} $LOGS > $UNKNOWNLOGS
+	if [ -s $UNKNOWNLOGS ] ; then
 		OUTPUT=$HTDOCS/$SECTION/unknown_failures.tpl
 		echo '<table class="righttable"><tr class="titlerow"><td class="titlecell">' > $OUTPUT
 		echo "Packages with failures not yet well known detected in $SECTION" >> $OUTPUT
 		echo '</td></tr><tr class="normalrow"><td class="contentcell2">' >> $OUTPUT
 		echo "<p>Please investigate and improve detection of known error types!</p>" >> $OUTPUT
 		echo '</td></tr><tr class="titlerow"><td class="alerttitlecell">Please file bugs!</td></tr></tr><tr class="normalrow"><td class="contentcell2" colspan="3">' >> $OUTPUT
-		COUNT=$(cut -d "_" -f1 $LOGS|sort -u|wc -l)
+		COUNT=$(cut -d "_" -f1 $UNKNOWNLOGS|sort -u|wc -l)
 		echo "<p>Affected packages in $SECTION: $COUNT</p>" >> $OUTPUT
 		echo "<ul>" >> $OUTPUT
-		for LOG in $(cat $LOGS) ; do
+		for LOG in $(cat $UNKNOWNLOGS) ; do
 			echo "<li><a href='/$SECTION/$LOG'>$LOG</a></li>" >> $OUTPUT
 		done
 		echo "</ul></td></tr></table>" >> $OUTPUT