[Piuparts-commits] rev 487 - piatti/home/piupartsm/bin piatti/home/piupartsm/bin/known_problems trunk

[Holger Levsen]

Author: holger
Date: 2009-08-18 07:27:27 +0000 (Tue, 18 Aug 2009)
New Revision: 487

Added:
   piatti/home/piupartsm/bin/known_problems/unknown_purge_error.conf
Removed:
   piatti/home/piupartsm/bin/known_problems/unknown_purge_failures.conf
Modified:
   piatti/home/piupartsm/bin/detect_well_known_errors
   piatti/home/piupartsm/bin/known_problems/command_not_found_issue.conf
   trunk/piuparts-report.py
Log:
fix detection of non-fatal issues

Modified: piatti/home/piupartsm/bin/detect_well_known_errors
===================================================================
--- piatti/home/piupartsm/bin/detect_well_known_errors	2009-08-18 06:08:01 UTC (rev 486)
+++ piatti/home/piupartsm/bin/detect_well_known_errors	2009-08-18 07:27:27 UTC (rev 487)
@@ -56,7 +56,13 @@
 			for LOG in $(cat $LOGS|sort) ; do
 				PACKAGE=$(echo $LOG | cut -d "_" -f1|cut -d "/" -f2)
 				LATEST=$(ls -tr1 --color=none $MASTER/$SECTION/fail/${PACKAGE}* $MASTER/$SECTION/bugged/${PACKAGE}* $MASTER/$SECTION/pass/${PACKAGE}* 2>/dev/null|tail -1|cut -d "/" -f7)
-				LATESTFAIL=$(ls -tr1 --color=none $MASTER/$SECTION/fail/${PACKAGE}* $MASTER/$SECTION/bugged/${PACKAGE}*  2>/dev/null|tail -1|cut -d "/" -f7-8)
+				if [ "${problem%_error.conf}_error.conf" == "$problem" ] ; then 
+					LATESTFAIL=$(ls -tr1 --color=none $MASTER/$SECTION/fail/${PACKAGE}* $MASTER/$SECTION/bugged/${PACKAGE}*  2>/dev/null|tail -1|cut -d "/" -f7-8)
+				else
+					# LATESTFAIL is actually a misnomer now, because its LATESTSUCCESS
+					# maybe it should be renamed to LATESTRELEVANT
+					LATESTFAIL=$(ls -tr1 --color=none $MASTER/$SECTION/pass/${PACKAGE}* 2>/dev/null|tail -1|cut -d "/" -f7-8)
+				fi
 				if [ "$LATEST" != "pass" ] && [ "$LATESTFAIL" == "$LOG" ] ; then 
 					echo "<li><a href='/$SECTION/$LOG'>$LOG</a></li>" >> $OUTPUT
 					echo "$LOG" >> ${KNOWNLOGS[$NR]}

Modified: piatti/home/piupartsm/bin/known_problems/command_not_found_issue.conf
===================================================================
--- piatti/home/piupartsm/bin/known_problems/command_not_found_issue.conf	2009-08-18 06:08:01 UTC (rev 486)
+++ piatti/home/piupartsm/bin/known_problems/command_not_found_issue.conf	2009-08-18 07:27:27 UTC (rev 487)
@@ -1,12 +1,10 @@
 #
 # detect packages which passed the piuparts test but have the string "command not found in their logs"
 #
-COMMAND=`rgrep "command not found" pass|grep -v "/var/lib/dpkg/info/openssh-client.postrm: line 34: delgroup: command not found" |cut -d " " -f1|sed -e "s#\.log:#.log#"|sort -u 2>/dev/null`
+COMMAND=`rgrep "command not found" pass |cut -d " " -f1|sed -e "s#\.log:#.log#"|sort -u 2>/dev/null`
 ISSUE=1
 HEADER='Packages which passed the piuparts test but have logs with the string "command not found"'
 HELPTEXT='
-<p>Failures due to #530501 (/var/lib/dpkg/info/openssh-client.postrm: line 34: delgroup: command not found) have been ignored.</p>
-
 <p>From the third paragraph about the meaning of the depends field in 
 <a href="http://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps">http://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps</a>:
 </p>

Copied: piatti/home/piupartsm/bin/known_problems/unknown_purge_error.conf (from rev 486, piatti/home/piupartsm/bin/known_problems/unknown_purge_failures.conf)
===================================================================
--- piatti/home/piupartsm/bin/known_problems/unknown_purge_error.conf	                        (rev 0)
+++ piatti/home/piupartsm/bin/known_problems/unknown_purge_error.conf	2009-08-18 07:27:27 UTC (rev 487)
@@ -0,0 +1,12 @@
+#
+# detect packages which try to overwrite other packages files
+#
+COMMAND=`rgrep -E "ERROR: Command failed .*'dpkg', '--purge', '--pending']" fail bugged|cut -d " " -f1|sed -e "s#\.log.*#.log#"|sort -u 2>/dev/null`
+ISSUE=0
+HEADER='Packages with failed logs because dpkg --purge --pending failed'
+HELPTEXT='
+<p>
+This is often because some dependencies have to be removed together and not seperatedly, and thus rather a bug in piuparts...
+</p>
+
+'


Property changes on: piatti/home/piupartsm/bin/known_problems/unknown_purge_error.conf
___________________________________________________________________
Added: svn:executable
   + *
Added: svn:mergeinfo
   + 

Modified: trunk/piuparts-report.py
===================================================================
--- trunk/piuparts-report.py	2009-08-18 06:08:01 UTC (rev 486)
+++ trunk/piuparts-report.py	2009-08-18 07:27:27 UTC (rev 487)
@@ -345,7 +345,7 @@
     "processes_running_error.tpl": "due to leaving processes running behind",
     "unowned_files_after_purge_error.tpl": "due to unowned files after purge",
     "conffile_prompt_error.tpl": "due to prompting due to modified conffiles",
-    "unknown_purge_failures.tpl": "dpkg --purge failed due to an unknown reason",
+    "unknown_purge_error.tpl": "dpkg --purge failed due to an unknown reason",
     "unknown_failures.tpl": "unclassified failures",
     "command_not_found_issue.tpl": "but logfile contains 'command not found'",
 }