[Piuparts-commits] [SCM] piuparts git repository branch, develop, updated. 0.50-78-g4d4af8d

[Andreas Beckmann]

The following commit has been merged in the develop branch:
commit d5aa1fda3f661362451b6f5789ad1b013d8699ac
Author: Andreas Beckmann <anbe at debian.org>
Date:   Tue Apr 9 11:02:19 2013 +0200

    p-r: gracefully handle missing binary packages
    
    These are usually udebs or binary packages for other architectures
    that are listed in the Binary field of the source package.
    Report them as unknown, but don't let them influence the overall
    test result for that binary package.
    
    Signed-off-by: Andreas Beckmann <anbe at debian.org>

diff --git a/debian/changelog b/debian/changelog
index 45c6c04..5eb4eff 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -27,6 +27,9 @@ piuparts (0.51) UNRELEASED; urgency=low
   * piuparts-analyze.py:
   * piuparts-report.py:
     - Skip sections that don't exist in piuparts.conf.
+    - "Missing" binary packages don't influence the overall test result of a
+      source package. These are either udebs or for other architectures.
+      (Closes: #699160)
   * Makefile:
   * detect_well_known_errors:
     - Skip sections that don't exist in piuparts.conf.
diff --git a/piuparts-report.py b/piuparts-report.py
index c43e4a6..e745cb2 100644
--- a/piuparts-report.py
+++ b/piuparts-report.py
@@ -926,11 +926,18 @@ class Section:
         failed = False
         binaryrows = ""
         for binary in sorted([x.strip() for x in binaries.split(",") if x.strip()]):
+          if not self._binary_db.has_package(binary):
+                # udebs or binary packages for other architectures
+                # The latter is a FIXME which needs parsing the Packages files from other archs too
+                binaryrows +=   "<tr class=\"normalrow\">" \
+                              + "<td class=\"labelcell\">Binary:</td>" \
+                              + "<td class=\"contentcell2\">%s</td>" \
+                                % binary \
+                              + "<td class=\"contentcell2\" colspan=\"4\">unknown package</td>" \
+                              + "</tr>\n"
+                continue
+
           state = self._binary_db.get_package_state(binary)
-          if state == "unknown":
-            # Don't track udebs and binary packages on other archs.
-            # The latter is a FIXME which needs parsing the Packages files from other archs too
-            continue
 
           if not "waiting" in state and "dependency" in state:
             state_style="lightalertlabelcell"

-- 
piuparts git repository