<p>Forwarding from BTS is apparently not working. Reply and forward to <a href="mailto:699059@bugs.debian.org">699059@bugs.debian.org</a>.</p>
<p>---------- Forwarded message ----------<br>
From: "Dave Steele" <<a href="mailto:dsteele@gmail.com">dsteele@gmail.com</a>><br>
Date: Jan 26, 2013 4:37 PM<br>
Subject: Elevate broken symlinks to error status<br>
To: <<a href="mailto:submit@bugs.debian.org">submit@bugs.debian.org</a>><br>
Cc: </p>
<p>> Package: piuparts<br>
> Severity: wishlist<br>
> Tags: patch<br>
> thanks<br>
><br>
><br>
> Provide better visibility to problems with broken symlinks in packages<br>
> by raising the condition from an issue to an error on piatti.<br>
><br>
> Per <a href="http://lists.alioth.debian.org/pipermail/piuparts-devel/2013-January/003424.html">http://lists.alioth.debian.org/pipermail/piuparts-devel/2013-January/003424.html</a><br>
> , the failed count will rise by no more than 500 due to this change,<br>
> even if nothing is done to fix the errors. The rise will be gradual,<br>
> taking about 6 months for all of the packages to recycle.<br>
><br>
> Since both blockers and block-ees will migrate only as the packages<br>
> are upgraded or recycled, it should be fairly easy to keep the<br>
> dependency-failed count due to this error to well under 1000.<br>
><br>
> <a href="https://github.com/davesteele/piuparts/commit/symlink-error">https://github.com/davesteele/piuparts/commit/symlink-error</a><br>
><br>
><br>
> I don't run the piatti configuration. The configuration file change is<br>
> trivial but untested.<br>
><br>
><br>
> ---<br>
> debian/changelog | 3 +++<br>
> instances/piuparts.conf.piatti | 2 +-<br>
> known_problems/broken_symlinks_error.conf | 2 +-<br>
> known_problems/broken_symlinks_issue.conf | 2 +-<br>
> piuparts-report.py | 2 +-<br>
> 5 files changed, 7 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/debian/changelog b/debian/changelog<br>
> index 5186305..10db500 100644<br>
> --- a/debian/changelog<br>
> +++ b/debian/changelog<br>
> @@ -22,6 +22,9 @@ piuparts (0.50) UNRELEASED; urgency=low<br>
> * slave_{run,join,cleanup}: Use pgrep to find running processes.<br>
> * detect_leftover_processes: Move statefile to slave-directory.<br>
><br>
> + [ David Steele ]<br>
> + * Elevate 'broken symlinks' to error status on piatti.<br>
> +<br>
> -- Andreas Beckmann <<a href="mailto:debian@abeckmann.de">debian@abeckmann.de</a>> Tue, 15 Jan 2013 11:51:43 +0100<br>
><br>
> piuparts (0.49) unstable; urgency=low<br>
> diff --git a/instances/piuparts.conf.piatti b/instances/piuparts.conf.piatti<br>
> index f41ac5b..df81e70 100644<br>
> --- a/instances/piuparts.conf.piatti<br>
> +++ b/instances/piuparts.conf.piatti<br>
> @@ -34,7 +34,7 @@ reschedule-fail-count = 15<br>
> [sid]<br>
> precedence = 1<br>
> description = Debian sid / main: package installation, removal and purge test.<br>
> -piuparts-flags = --scriptsdir /etc/piuparts/scripts-leftovers<br>
> +piuparts-flags = --scriptsdir /etc/piuparts/scripts-leftovers<br>
> --fail-on-broken-symlinks<br>
> # Once there are no packages left which leave files on purge behind,<br>
> # --pedantic-purge-test should be added<br>
> distro = sid<br>
> diff --git a/known_problems/broken_symlinks_error.conf<br>
> b/known_problems/broken_symlinks_error.conf<br>
> index 580b184..135ba05 100644<br>
> --- a/known_problems/broken_symlinks_error.conf<br>
> +++ b/known_problems/broken_symlinks_error.conf<br>
> @@ -6,5 +6,5 @@ WHERE='fail bugged affected'<br>
> ISSUE=1<br>
> HEADER='Packages which have logs with the string "Broken symlinks"'<br>
> HELPTEXT='<br>
> -<p>This is clearly an error, but as there are too many of this kind,<br>
> piuparts can be configured to not fail if it detects broken symlinks.<br>
> Another option is not to test for broken symlinks. See the <a<br>
> href="<a href="http://piuparts.debian.org/doc/piuparts.1.html">http://piuparts.debian.org/doc/piuparts.1.html</a>"<br>
> target="_blank">piuparts manpage</a> for details.</p><br>
> +<p>Symlinks remaining after the targets are deleted.</p><br>
> '<br>
> diff --git a/known_problems/broken_symlinks_issue.conf<br>
> b/known_problems/broken_symlinks_issue.conf<br>
> index 5cdfafe..1e17460 100644<br>
> --- a/known_problems/broken_symlinks_issue.conf<br>
> +++ b/known_problems/broken_symlinks_issue.conf<br>
> @@ -6,5 +6,5 @@ WHERE='pass'<br>
> ISSUE=1<br>
> HEADER='Packages which have logs with the string "Broken symlinks"'<br>
> HELPTEXT='<br>
> -<p>This is clearly an error, but as there are too many of this kind,<br>
> piuparts can be configured to not fail if it detects broken symlinks.<br>
> Another option is not to test for broken symlinks. See the <a<br>
> href="<a href="http://piuparts.debian.org/doc/piuparts.1.html">http://piuparts.debian.org/doc/piuparts.1.html</a>"<br>
> target="_blank">piuparts manpage</a> for details.</p><br>
> +<p>Symlinks remaining after the targets are deleted.</p><br>
> '<br>
> diff --git a/piuparts-report.py b/piuparts-report.py<br>
> index ab84c56..58dd6bc 100644<br>
> --- a/piuparts-report.py<br>
> +++ b/piuparts-report.py<br>
> @@ -353,6 +353,7 @@ linktarget_by_template = [<br>
> ("obsolete_conffiles_issue.tpl", "but logfile reports obsolete conffiles"),<br>
><br>
> ("dependency_error.tpl", "due to unsatisfied dependencies"),<br>
> + ("broken_symlinks_error.tpl", "due to 'broken symlinks'"),<br>
> ("packages_have_been_kept_back_error.tpl", "...and logfile also<br>
> contains 'packages have been kept back'"),<br>
> ("command_not_found_error.tpl", "due to a 'command not found' error"),<br>
> ("files_in_usr_local_error.tpl", "due to files in /usr/local"),<br>
> @@ -380,7 +381,6 @@ linktarget_by_template = [<br>
> ("cron_error_after_removal_error.tpl", "due to errors from<br>
> cronjob after removal"),<br>
> ("logrotate_error_after_removal_error.tpl", "due to errors from<br>
> logrotate after removal"),<br>
> ("installs_over_symlink_error.tpl", "...and package installs<br>
> something over existing symlinks"),<br>
> - ("broken_symlinks_error.tpl", "...and logfile also contains<br>
> 'broken symlinks'"),<br>
> ("obsolete_conffiles_error.tpl", "...and logfile reports obsolete<br>
> conffiles"),<br>
> ("unknown_failures.tpl", "due to unclassified failures"),<br>
> ]<br>
> --<br>
> 1.7.10.4<br>
</p>