[Pkg-alsa-devel] Bug#272998: alsa-lib: FTBFS on alpha

[Steve Langasek]

--LZFKeWUZP29EKQNE
Content-Type: multipart/mixed; boundary="JbKQpFqZXJ2T76Sg"
Content-Disposition: inline


--JbKQpFqZXJ2T76Sg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

tags 272998 patch
thanks

With further investigation it appears that the reason previous versions
of alsa-lib built successfully on alpha was actually that something
external to the source tree was defining PIC for us, causing the
versioned symbol code to be used across the board instead of pulling in
the non-portable ".set" directives.

I've confirmed that the use of .symver instead of weak symbol aliases in
static libs doesn't cause any immediately visible usability problems.
Therefore, the attached minimally-intrusive patch to force the use of=20
=2Esymver on alpha should fix the FTBFS, in spite of its ugliness.

A cleaner fix would require input from someone well-versed in alpha
assembly.

--=20
Steve Langasek
postmodern programmer

--JbKQpFqZXJ2T76Sg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="alsa-lib-272998.diff"
Content-Transfer-Encoding: quoted-printable

diff -u alsa-lib-1.0.6/debian/changelog alsa-lib-1.0.6/debian/changelog
--- alsa-lib-1.0.6/debian/changelog
+++ alsa-lib-1.0.6/debian/changelog
@@ -1,3 +1,12 @@
+alsa-lib (1.0.6-1.1) unstable; urgency=3Dlow
+
+  * Non-maintainer upload.
+  * Fix use of embedded assembly so that we always use symbol versioning
+    instead of weak symbol aliases on alpha, since the assembly used for
+    weak symbols is apparently non-portable.  Closes: #272998.
+
+ -- Steve Langasek <vorlon@debian.org>  Fri, 24 Sep 2004 16:20:20 -0700
+
 alsa-lib (1.0.6-1) unstable; urgency=3Dlow
=20
   * New upstream release.
only in patch2:
unchanged:
--- alsa-lib-1.0.6.orig/include/alsa-symbols.h
+++ alsa-lib-1.0.6/include/alsa-symbols.h
@@ -43,7 +43,7 @@
 	__asm__ (".symver " #real "," #name "@@" #version)
 #endif
=20
-#ifdef USE_VERSIONED_SYMBOLS
+#if defined(USE_VERSIONED_SYMBOLS) || defined(__alpha__)
 #define use_symbol_version(real, name, version) \
 		symbol_version(real, name, version)
 #define use_default_symbol_version(real, name, version) \

--JbKQpFqZXJ2T76Sg--

--LZFKeWUZP29EKQNE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBVK2SKN6ufymYLloRAhHWAJ9e08XPJpjHm9PBwcA+rD5dimO2hgCgy+lT
pYHkLYZJNbjHxKlFnrp7mEs=
=+IRI
-----END PGP SIGNATURE-----

--LZFKeWUZP29EKQNE--