[Pkg-audacious-maintainers] Bug#514674: audacious: Segfaults when opening ape file

[John Lindgren]

What was happening, I think, is that the decoder was trying to read data
past the end of a truncated frame, causing an invalid memory access. I
added code which prevents reading too far and instead fills the rest of
the output buffer with zeros. For the file you gave me the link to, the
result is that it spits out some error messages and keeps playing, but
with some sections of silence and random noise. I don't know if there's
a way to detect and prevent the noise, but I hope it's at least better
than a segmentation fault?

I'm attaching a patched binary of the .ape plugin
(/usr/lib/audacious/Input/demac.so) for Lenny i386, so you can try it
for yourself if you trust me.

John Lindgren

----- Original Message -----
From: Luís Picciochi Oliveira <pitxyoki at gmail.com>
To: John Lindgren <john.lindgren at tds.net>
Subject: Re: audacious: Segfaults when opening ape file
Date: Fri, 20 Mar 2009 17:05:23 +0000

Just out of curiosity, what will it do? Continue (as mplayer does) or
will it stop playing the track?

Thanks,
Luís Picciochi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: demac.so
Type: application/x-sharedlib
Size: 141886 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-audacious-maintainers/attachments/20090320/83b3b7b2/attachment-0001.bin