[pkg-bacula-devel] Bug#646730: Bug#646730: bacula: drops readline support if rebuilt

Luca Capello luca at pca.it
Thu May 17 19:38:20 UTC 2012


tags 646730 + pending
usertags 646730 + debian-packaging
thanks

Hi there!

On Wed, 26 Oct 2011 18:33:42 +0200, Sven Joachim wrote:
> ,----
> | Configuration on Fri Oct 21 15:28:34 UTC 2011:
> | [...]
> |    Large file support:	    yes
> |    Bacula conio support:    no 
> |    readline support:	    no 
> `----
>
> Adding libncurses-dev to Build-Depends should avoid this.

First, I thought this was due to the split between libncurses and
libtinfo, in a sort "reflected" in the readline debian/changelog:

--8<---------------cut here---------------start------------->8---
readline6 (6.2-6) unstable; urgency=low

  * lib{,32}readline6-dev: Depend on lib{,32}tinfo-dev instead of
    lib{,32}ncurses5-dev.
  * Don't link rlfe against any libncurses* library.

 -- Matthias Klose <doko at debian.org>  Tue, 04 Oct 2011 16:33:44 +0200

readline6 (6.2-5) unstable; urgency=low

  * Do not link against any libncurses* library, just against libtinfo.
  * Fix corrupt display for history search in vi-mode, 256-color prompt
    (Micah Cowan). Closes: #614718, LP: #721982.
  * Remove unused build-dep on lsb-release. Closes: #642383.

 -- Matthias Klose <doko at debian.org>  Sat, 01 Oct 2011 11:56:50 +0200

--8<---------------cut here---------------end--------------->8---

However, simply adding libtinfo-dev was not enough, here are the
differences in my pbuilder logs with libtinfo-dev and libncurses-dev:

--8<---------------cut here---------------start------------->8---
--- libtinfo-dev	2012-05-17 20:09:22.560774742 +0200
+++ libncurses-dev	2012-05-17 20:20:54.038045505 +0200
@@ -1470,13 +1450,13 @@
 checking whether to use NLS... yes
 checking where the gettext function comes from... libc
 checking for msgfmt... (cached) /usr/bin/msgfmt
-checking curses.h usability... no
-checking curses.h presence... no
-checking for curses.h... no
-checking for curses.h... (cached) no
-checking term.h usability... no
-checking term.h presence... no
-checking for term.h... no
+checking curses.h usability... yes
+checking curses.h presence... yes
+checking for curses.h... yes
+checking for tgetent in -lncurses... yes
+checking /usr/include/readline/readline.h usability... yes
+checking /usr/include/readline/readline.h presence... yes
+checking for /usr/include/readline/readline.h... yes
 checking whether stat file-mode macros are broken... no
 checking for dirent.h that defines DIR... yes
 checking for library containing opendir... none required
@@ -1551,10 +1531,12 @@
 checking termios.h usability... yes
 checking termios.h presence... yes
 checking for termios.h... yes
-checking termcap.h usability... no
-checking termcap.h presence... no
-checking for termcap.h... no
-checking for term.h... (cached) no
+checking termcap.h usability... yes
+checking termcap.h presence... yes
+checking for termcap.h... yes
+checking term.h usability... yes
+checking term.h presence... yes
+checking for term.h... yes
 checking for unistd.h... (cached) yes
 checking sys/bitypes.h usability... yes
 checking sys/bitypes.h presence... yes
@@ -1889,9 +1871,6 @@
 make[2]: Leaving directory `/tmp/buildd/bacula-5.0.3/debian/tmp-build-sqlite3/src/tray-monitor'
 ==>Entering directory /tmp/buildd/bacula-5.0.3/debian/tmp-build-sqlite3/src/console
 make[2]: Entering directory `/tmp/buildd/bacula-5.0.3/debian/tmp-build-sqlite3/src/console'
-conio.c:87:21: fatal error: termcap.h: No such file or directory
-compilation terminated.
-make[2]: *** [depend] Error 1
 make[2]: Leaving directory `/tmp/buildd/bacula-5.0.3/debian/tmp-build-sqlite3/src/console'
 ==>Entering directory /tmp/buildd/bacula-5.0.3/debian/tmp-build-sqlite3/src/plugins/fd
 make[2]: Entering directory `/tmp/buildd/bacula-5.0.3/debian/tmp-build-sqlite3/src/plugins/fd'
@@ -1974,7 +1953,7 @@
 make[2]: Leaving directory `/tmp/buildd/bacula-5.0.3/debian/tmp-build-sqlite3/platforms'
 make[1]: Leaving directory `/tmp/buildd/bacula-5.0.3/debian/tmp-build-sqlite3'
 
-Configuration on Thu May 17 18:00:59 UTC 2012:
+Configuration on Thu May 17 18:11:52 UTC 2012:
 
    Host:		    x86_64-pc-linux-gnu -- debian wheezy/sid
    Bacula version:	    Bacula 5.0.3 (04 August 2010)
@@ -2024,8 +2003,8 @@
    SQL binaries Directory   /usr/bin
 
    Large file support:	    yes
-   Bacula conio support:    no 
-   readline support:	    no 
+   Bacula conio support:    no -lreadline -lhistory -lncurses
+   readline support:	    yes 
    TCP Wrappers support:    yes -lwrap
    TLS support: 	    yes
    Encryption support:	    yes
@@ -2366,8 +2345,8 @@
 Compiling authenticate.c
 authenticate.c: In function 'int authenticate_director(JCR*, DIRRES*, CONRES*)':
 authenticate.c:65:9: warning: variable 'tls_needed' set but not used [-Wunused-but-set-variable]
-/tmp/buildd/bacula-5.0.3/debian/tmp-build-sqlite3/libtool --silent --tag=CXX --mode=link /usr/lib/ccache/x86_64-linux-gnu-g++   -L../lib -L../cats -o bconsole console.o console_conf.o authenticate.o  \
-	        -lbaccfg -lbac -lm -lpthread -ldl   \
+/tmp/buildd/bacula-5.0.3/debian/tmp-build-sqlite3/libtool --silent --tag=CXX --mode=link /usr/lib/ccache/x86_64-linux-gnu-g++  -L/usr/include/readline -L../lib -L../cats -o bconsole console.o console_conf.o authenticate.o  \
+	       -lreadline -lhistory -lncurses -lbaccfg -lbac -lm -lpthread -ldl   \
 	      -lssl -lcrypto
 ==== Make of console is good ====

--8<---------------cut here---------------end--------------->8---

Though, we are missing termcap.h...

> However,
> consider patching the upstream build system which erroneously believes
> that ncurses is necessary for linking with readline.

While I am not an ncurses/readline expert, I think that upstream is
correct, according to the upstream manual:

  <http://www.bacula.org/5.2.x-manuals/en/main/main/System_Requirements.html>

  * If you want to enable command line editing and history, you will
    need to have /usr/include/termcap.h and either the termcap or the
    ncurses library loaded (libtermcap-devel or ncurses-devel).

Fix applied in the Git repository:

  <http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commitdiff;h=c71e91fb4d6f7434786f1d36eeeb0b0506a2216c>

Thx, bye,
Gismo / Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-bacula-devel/attachments/20120517/67c975dc/attachment-0001.pgp>


More information about the pkg-bacula-devel mailing list