[Pkg-bazaar-maint] Bug#435112: bzr branches returns cryptic error instead of underlying connect error

[Loïc Minier]

Package: bzrtools
Version: 0.18.0-1
Severity: minor

        Hi,

 bzr branches bzr://bzr.debian.org/bzr/pkg-maemo/hildon-desktop/ubuntu
 throws:
bzr: ERROR: bzrlib.errors.TooManyConcurrentRequests: The medium '<bzrlib.smart.medium.SmartTCPClientMedium object at 0xb6e9b32c>' has reached its concurrent request limit. Be sure to finish_writing and finish_reading on the currently open request.

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 729, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 691, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.4/site-packages/bzrlib/commands.py", line 389, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/__init__.py", line 486, in run
    return branches(location)
  File "/usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/branches.py", line 15, in branches
    for branch in iter_branches(t, lister):
  File "/usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/bzrtools.py", line 311, in iter_branches
    for bzrdir in iter_bzrdirs(t, lister):
  File "/usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/bzrtools.py", line 345, in iter_bzrdirs
    for directory in lister(t):
  File "/usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/bzrtools.py", line 337, in lister
    return t.list_dir('.')
  File "/usr/lib/python2.4/site-packages/bzrlib/transport/remote.py", line 436, in list_dir
    resp = self._call2('list_dir', self._remote_path(relpath))
  File "/usr/lib/python2.4/site-packages/bzrlib/transport/remote.py", line 181, in _call2
    return self._client.call(method, *args)
  File "/usr/lib/python2.4/site-packages/bzrlib/smart/client.py", line 30, in call
    result, protocol = self.call_expecting_body(method, *args)
  File "/usr/lib/python2.4/site-packages/bzrlib/smart/client.py", line 42, in call_expecting_body
    request = self._medium.get_request()
  File "/usr/lib/python2.4/site-packages/bzrlib/smart/medium.py", line 412, in get_request
    return SmartClientStreamMediumRequest(self)
  File "/usr/lib/python2.4/site-packages/bzrlib/smart/medium.py", line 566, in __init__
    raise errors.TooManyConcurrentRequests(self._medium)
TooManyConcurrentRequests: The medium '<bzrlib.smart.medium.SmartTCPClientMedium object at 0xb6e9b32c>' has reached its concurrent request limit. Be sure to finish_writing and finish_reading on the currently open request.

bzr 0.18.0 on python 2.4.4.final.0 (linux2)
arguments: ['/usr/bin/bzr', 'branches', 'bzr://bzr.debian.org/bzr/pkg-maemo/hildon-desktop/ubuntu']

** please send this report to bazaar at lists.ubuntu.com

 while bzr ls shows:
bzr: ERROR: Connection error: failed to connect to bzr.debian.org:4155: Connection refused 

 I think bzr branches should display the error in a similar way; bzr
 branches fails in a way which suggest an internal error or that the
 target server is too busy, while the problem is really a connection
 error.

   Bye,

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-1-686 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages bzrtools depends on:
ii  bzr                           0.18-1     Bazaar, the next-generation distri
ii  patch                         2.5.9-4    Apply a diff file to an original
ii  python                        2.4.4-6    An interactive high-level object-o
ii  python-central                0.5.14     register and build utility for Pyt

Versions of packages bzrtools recommends:
ii  graphviz                      2.12-3     rich set of graph drawing tools
ii  rsync                         2.6.9-3    fast remote file copy program (lik

-- no debconf information

-- 
Loïc Minier