[Pkg-bitcoin-commits] [python-quamash] 103/269: ProcessPoolExecutor works, now which significantly adds to complexity of tests.

[Jonas Smedegaard]

This is an automated email from the git hooks/post-receive script.

js pushed a commit to branch master
in repository python-quamash.

commit 6f138119f4633178bf8fbd40a2779125ca849ee9
Author: Mark Harviston <mark.harviston at gmail.com>
Date:   Fri Jul 18 01:17:25 2014 -0700

    ProcessPoolExecutor works, now which significantly adds to complexity of tests.
---
 tests/test_qeventloop.py | 45 ++++++++++++++++++++++++++-------------------
 1 file changed, 26 insertions(+), 19 deletions(-)

diff --git a/tests/test_qeventloop.py b/tests/test_qeventloop.py
index cccbf87..a019770 100644
--- a/tests/test_qeventloop.py
+++ b/tests/test_qeventloop.py
@@ -5,7 +5,9 @@ import asyncio
 import locale
 import logging
 import sys
-from concurrent.futures import ThreadPoolExecutor, ProcessPoolExecutor  # noqa
+import ctypes
+import multiprocessing
+from concurrent.futures import ThreadPoolExecutor, ProcessPoolExecutor
 
 try:
 	from PyQt5.QtWidgets import QApplication
@@ -54,8 +56,7 @@ def loop(request, application):
 
 
 @pytest.fixture(
-	params=[None, quamash.QThreadExecutor, ThreadPoolExecutor],
-	#  ProcessPoolExecutor may never work
+	params=[None, quamash.QThreadExecutor, ThreadPoolExecutor, ProcessPoolExecutor]
 )
 def executor(request):
 	exc_cls = request.param
@@ -67,30 +68,36 @@ def executor(request):
 	return exc
 
 
-def test_can_run_tasks_in_executor(loop, executor):
-	"""Verify that tasks can be run in an executor."""
-	logging.debug('Executor: {!r}'.format(executor))
-
-	def blocking_func():
+class TestCanRunTasksInExecutor:
+	"""
+	This needs to be a class because pickle can't serialize closures,
+	but can serialize bound methods.
+	multiprocessing can only handle pickleable functions.
+	"""
+	def test_can_run_tasks_in_executor(self, loop, executor):
+		"""Verify that tasks can be run in an executor."""
+		logging.debug('Executor: {!r}'.format(executor))
+		logging.debug('Executor: {!r}'.format(loop))
+
+		manager = multiprocessing.Manager()
+		was_invoked = manager.Value(ctypes.c_int, 0)
+		logging.debug('running until complete')
+		loop.run_until_complete(self.blocking_task(loop, executor, was_invoked))
+		logging.debug('ran')
+		assert was_invoked.value == 1
+
+	def blocking_func(self, was_invoked):
 		logging.debug('start blocking_func()')
-		nonlocal was_invoked
-		was_invoked = True
+		was_invoked.value = 1
 		logging.debug('end blocking_func()')
 
 	@asyncio.coroutine
-	def blocking_task():
+	def blocking_task(self, loop, executor, was_invoked):
 		logging.debug('start blocking task()')
-		fut = loop.run_in_executor(executor, blocking_func)
+		fut = loop.run_in_executor(executor, self.blocking_func, was_invoked)
 		yield from asyncio.wait_for(fut, timeout=1.0)
 		logging.debug('start blocking task()')
 
-	was_invoked = False
-	logging.debug('running until complete')
-	loop.run_until_complete(blocking_task())
-	logging.debug('ran')
-
-	assert was_invoked
-
 
 def test_can_handle_exception_in_default_executor(loop):
 	"""Verify that exceptions from tasks run in default (threaded) executor are handled."""

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-bitcoin/python-quamash.git