[Pkg-bluetooth-maintainers] RFC: libbtctl

[Filippo Giunchedi]

Hi Mario,

On Fri, Dec 22, 2006 at 03:48:02AM +0100, Mario Iseli wrote:
> Hello comaintainers,
> 
> in the last days I worked a little bit on libbtctl which is in our SVN
> repository, you can just run svn-buildpackage in the trunk directory and
> it will do the rest for you. Then please have a look at the package, I
> know, it's not yet perfect but I think it also doesn't have some really
> bad mistakes. What are your suggestions?

I found some problems: (in order of importance)
* your ./configure call depends on config.status which in turn has no
  prerequisites in debian/rules, config.status however is never removed except
  by make distclean, which is never called by debian/rules.

* debian/python-libbtctl.install shows some duplicate file patterns
  (I'm not even sure if pycentral is needed, the package ships only a .so
  python-wise)

* there's a debian/patches/ directory, however the patch (is it useful?) is
  never applied


before continuing I have a few remarks to do:
- it is not clear to me why you switched from cdbs to debhelper (with the latter
  being a "subset" of the former)
- it is not clear why you switched to "mergeWithUpstream" mode of
  svn-buildpackage

thanks,
filippo
--
Filippo Giunchedi - http://esaurito.net
PGP key: 0x6B79D401
random quote follows:

Date: Tuesday, 2002/10/22 - 08:09
dselect proves the existence of Satan. It's the worst part of Debian.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-bluetooth-maintainers/attachments/20061222/150cd395/attachment.pgp