[Pkg-chromium-maint] Bug#588856: Bug#588856: gyp: broken on kfreebsd-*: KeyError: 'gnukfreebsd8'

[Jakub Wilk]

* Giuseppe Iuculano <giuseppe at iuculano.it>, 2010-07-13, 11:41:
>> $ gyp
>> Traceback (most recent call last):
>>   File "/usr/bin/gyp", line 18, in <module>
>>     sys.exit(gyp.main(sys.argv[1:]))
>>   File "/usr/lib/pymodules/python2.6/gyp/__init__.py", line 316, in main
>>     'sunos5':   'make',}[sys.platform] ]
>> KeyError: 'gnukfreebsd8'
>
>Coould you try to apply this patch to
>"/usr/lib/pymodules/python2.6/gyp/__init__.py" please?
>
>
>--- a/pylib/gyp/__init__.py
>+++ b/pylib/gyp/__init__.py
>@@ -312,6 +312,7 @@ def main(args):
>                            'cygwin':   'msvs',
>                            'freebsd7': 'make',
>                            'freebsd8': 'make',
>+                           'gnukfreebsd8': 'make',
>                            'linux2':   'make',
>                            'openbsd4': 'make',
>                            'sunos5':   'make',}[sys.platform] ]

Yes, this does the trick in my particular case, but doesn't scale well: 
you would have to add 'gnukfreebsd7', 'gnu0' and who knows what else[0]. 
The attached patch should do better job: it falls back to 'make' for 
everything else than win32, cygwin or darwin.

[0] In python2.5 there were e.g. 'linux2-alpha', 'linux2-hppa' and a few 
other platforms; thankfully, they are gone in python2.6 (AFAIK).

-- 
Jakub Wilk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 588856.diff
Type: text/x-diff
Size: 779 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-chromium-maint/attachments/20100714/b3618d93/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-chromium-maint/attachments/20100714/b3618d93/attachment.pgp>