[Pkg-chromium-maint] Bug#589160: chromium-browser: FTBFS if built twice in a row

[Timo Juhani Lindfors]

Package: chromium-browser
Version: 5.0.375.99~r51029-3+arm1
Severity: normal
Tags: patch

Steps to reproduce:
1) dpkg-source -x chromium-browser_5.0.375.99~r51029-3+arm1.dsc
(where 1199f9003057dfb2609e014fe9237800  chromium-browser_5.0.375.99~r51029-3+arm1.dsc)
2) cd chromium-browser_5.0.375.99~r51029
3) dpkg-buildpackage -us -uc
4) dpkg-buildpackage -us -uc

Expected results:
3 & 4) chromium-browser builds from souce

Actual results:
4) build fails with

Script started on Thu Jul 15 11:58:20 2010
dpkg-buildpackage: export CPPFLAGS from dpkg-buildflags (origin: vendor): 
dpkg-buildpackage: export CFLAGS from dpkg-buildflags (origin: vendor): -g -O2
dpkg-buildpackage: export CXXFLAGS from dpkg-buildflags (origin: vendor): -g -O2
dpkg-buildpackage: export FFLAGS from dpkg-buildflags (origin: vendor): -g -O2
dpkg-buildpackage: export LDFLAGS from dpkg-buildflags (origin: vendor): 
dpkg-buildpackage: source package chromium-browser
dpkg-buildpackage: source version 5.0.375.99~r51029-3+arm1
dpkg-buildpackage: source changed by Giuseppe Iuculano <iuculano at debian.org>
dpkg-buildpackage: host architecture armel
 debian/rules clean
test -x debian/rules
dh_testroot
rmdir /root/debian-chromium-browser/chromium-browser-5.0.375.99~r51029/src
rmdir: failed to remove `/root/debian-chromium-browser/chromium-browser-5.0.375.99~r51029/src': Directory not empty
make: [cleanbuilddir] Error 1 (ignored)
rm -f debian/stamp-makefile-build debian/stamp-makefile-install
MAKEFLAGS=-j6 /usr/bin/make  -C /root/debian-chromium-browser/chromium-browser-5.0.375.99~r51029/src CFLAGS="-g -O2 -g -Wall -O2" CXXFLAGS="-g -O2 -g -Wall -O2" CPPFLAGS="" LDFLAGS=""  -k clean
make[1]: Entering directory `/root/debian-chromium-browser/chromium-browser-5.0.375.99~r51029/src'
make[1]: *** No rule to make target `clean'.
make[1]: Leaving directory `/root/debian-chromium-browser/chromium-browser-5.0.375.99~r51029/src'
make: [makefile-clean] Error 2 (ignored)
for i in ./src/sdch/open-vcdiff/config.guess ./src/third_party/yasm/source/patched-yasm/config/config.guess ./src/third_party/sqlite/config.guess ./src/third_party/tcmalloc/vendor/config.guess ./src/third_party/libevent/config.guess ./src/third_party/libxml/config.guess ./src/third_party/icu/source/config.guess ./src/native_client/src/third_party/libxt/config.guess ./src/sdch/open-vcdiff/config.sub ./src/third_party/yasm/source/patched-yasm/config/config.sub ./src/third_party/sqlite/config.sub ./src/third_party/tcmalloc/vendor/config.sub ./src/third_party/libevent/config.sub ./src/third_party/libxml/config.sub ./src/third_party/icu/source/config.sub ./src/native_client/src/third_party/libxt/config.sub ./src/third_party/yasm/source/patched-yasm/config/config.rpath ; do \
		if test -e $i.cdbs-orig ; then \
			mv $i.cdbs-orig $i ; \
		fi ; \
	done
dh_clean 
rm -f debian/configure-stamp debian/stamp-makefile-build-*
rm -f *.cdbs-config_list debian/chromium-browser.sh 
 dpkg-source -b chromium-browser-5.0.375.99~r51029
dpkg-source: info: using source format `3.0 (quilt)'
dpkg-source: info: building chromium-browser using existing ./chromium-browser_5.0.375.99~r51029.orig.tar.bz2
dpkg-source: error: cannot represent change to chromium-browser-5.0.375.99~r51029/src/tools/data_pack/repack.pyc: binary file contents changed
dpkg-source: error: add src/tools/data_pack/repack.pyc in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to chromium-browser-5.0.375.99~r51029/src/tools/data_pack/data_pack.pyc: binary file contents changed
dpkg-source: error: add src/tools/data_pack/data_pack.pyc in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to chromium-browser-5.0.375.99~r51029/src/tools/grit/grit/util.pyc: binary file contents changed
dpkg-source: error: add src/tools/grit/grit/util.pyc in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to chromium-browser-5.0.375.99~r51029/src/tools/grit/grit/grit_runner.pyc: binary file contents changed
dpkg-source: error: add src/tools/grit/grit/grit_runner.pyc in debian/source/include-binaries if you want to store the modified binary in the debian tarball
...

Suggested fix:
1) add

	rm -fr src/out
	find src/tools -name "*.pyc" | xargs rm -f

to the clean target of debian/rules