[Pkg-chromium-maint] Bug#589654: chromium-browser: build with WANT_TESTS=0 after build with WANT_TESTS=1 fails

[Jonathan Nieder]

Source: chromium-browser
Version: 5.0.375.99~r51029-4
Severity: wishlist
Justification: not documented to work, though I think it should
Tags: patch

Built once with default settings, then tried to build again with
WANT_TESTS=0.  The result:

| ( cd /home/jrn/src/chromium-browser.sid/src/out/Release && tar --exclude=lib --exclude=lib.target --exclude=obj --exclude=obj.target --exclude=obj.host --exclude=opt --exclude=dbg --exclude=plugins --exclude='*.d' --exclude=.deps --exclude=calendar_app --exclude=docs_app --exclude=gmail_app --exclude=pyproto -cf - . ) | \
|         ( cd debian/tmp/usr/lib/chromium-browser && tar xvf - )
| ./
| ./startup_tests
| ./net_perftests
| ./chrome.1
[...]
| # Look for duplicates, fail if we find any
|  => No duplicate found
| # Find missing
| --- /tmp/pkg-18797.inhammer     2010-07-19 11:19:47.190000575 -0500
| +++ /tmp/pkg-18797.indebs       2010-07-19 11:19:47.100000575 -0500
| @@ -1,20 +1,8 @@
| -chromium-browser/app_unittests
| -chromium-browser/base_unittests
|  chromium-browser/chrome.pak
|  chromium-browser/chromium-browser
|  chromium-browser/chromium-browser-sandbox
| -chromium-browser/core
|  chromium-browser/ffmpegsumo_nolink
[...]

Fix:

diff --git a/debian/rules b/debian/rules
index 7bde408..649d021 100755
--- a/debian/rules
+++ b/debian/rules
@@ -289,7 +289,6 @@ TESTS_TARGETS := \
 	wav_ola_test \
 	$(NULL)
 
-ifeq (1,$(WANT_TESTS))
 INSTALL_EXCLUDE_FILES += \
 	$(TESTS_TARGETS) \
 	test_shell.pak \
@@ -299,7 +298,6 @@ INSTALL_EXCLUDE_FILES += \
 INSTALL_EXCLUDE_DIRS += \
 	app_unittests_strings \
 	$(NULL)
-endif
 
 ifeq (1,$(WANT_SANDBOXING))
 GYP_DEFINES += \
--