[pkg-cinnamon] Bug#761309: cinnamon-common: The digital photo frame desklet fails to open the image with middle-click

[Martín Ferrari]

Package: cinnamon-common
Version: 2.2.16-3
Severity: normal

Hi,

According to the README, middle-clicking on the desklet would open the image in
an external program, but this does not work. It is a combination of using an
unescaped command-line to pass file names (which fails if there are spaces),
and not actually passing the filename, but an object.

This patch solves the issue:

--- /tmp/desklet.js.orig	2014-09-12 20:29:09.953439595 +0100
+++ /tmp/desklet.js.orig2	2014-09-12 20:32:48.453444788 +0100
@@ -225,8 +225,8 @@
             if (event.get_button() == 1) {
                 this._update();
             }
-            else if (event.get_button() == 2) {     
-                Util.spawnCommandLine("xdg-open " + this.currentPicture);                
+            else if (event.get_button() == 2) {
+                Util.spawn(["xdg-open", this.currentPicture._path]);
             }            
         }
         catch (e) {


-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing'), (100, 'unstable'), (50, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.14-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages cinnamon-common depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.20.0-2
ii  gir1.2-meta-muffin-0.0                       2.2.6-3
ii  python                                       2.7.8-1
ii  python-pil                                   2.5.3-1

cinnamon-common recommends no packages.

cinnamon-common suggests no packages.

-- no debconf information