[Pkg-clamav-devel] clamsmtp

Scott Kitterman debian at kitterman.com
Mon Nov 17 19:15:25 UTC 2008 

On Monday 17 November 2008 12:04:58 Scott Kitterman wrote:
> On Monday 17 November 2008 11:09, Michael Meskes wrote:
> > I just took over maintenance of clamsmtp with approval of the current
> > maintainer and uploaded my patched version to get rid of the RC bug in
> > there. But now I wonder whether it would make sense to move this package
> > to this group as well. What do others think?
>
> I think there was general consensus that this was appropriate if someone
> wanted to.
>
> I've done most of the uploading of clamsmtp in Ubuntu recently.  I confess
> I've been remiss about sending patches back since it didn't appear anyone
> was listening.  I'll have a look and see if there's anything useful.
>
Here's what I have:

Option name needs updating in config file:

diff -ruN clamsmtp-1.8/debian/clamsmtpd.conf 
clamsmtp-1.10/debian/clamsmtpd.conf
--- clamsmtp-1.8/debian/clamsmtpd.conf	2008-11-17 13:30:50.000000000 -0500
+++ clamsmtp-1.10/debian/clamsmtpd.conf	2008-11-17 13:22:41.000000000 -0500
@@ -24,7 +24,7 @@
 ClamAddress: /var/run/clamav/clamd.ctl
 
 # A header to add to all scanned email
-#ScanHeader: X-AV-Checked: ClamAV using ClamSMTP
+#Header: X-AV-Checked: ClamAV using ClamSMTP
 
 # Directory for temporary files
 TempDirectory: /var/spool/clamsmtp

It turns out the upstream author's name, Nate Nielsen, was a pseudonym and he 
came clean in later version.  I've attached an updated debian/copyright for 
when you update to the newer version.  Also the current debian/copyright 
misses some information about common/compat.c.  Home page ends up changing 
too.  Updated debian/watch file attached.

http://memberwebs.com/stef/

I had some other postinst changes too.  Before I made these changes, 
install/upgrade bugs in Ubuntu were reasonably frequent.  Since there have 
been none.  Details in 
https://bugs.launchpad.net/ubuntu/+source/clamsmtp/+bug/108303



diff -ruN clamsmtp-1.8/debian/postinst clamsmtp-1.10/debian/postinst
--- clamsmtp-1.8/debian/postinst	2008-11-17 13:30:50.000000000 -0500
+++ clamsmtp-1.10/debian/postinst	2008-11-17 13:22:41.000000000 -0500
@@ -67,10 +72,18 @@
         return 1
     fi
 
-    adduser --system --group --no-create-home \
+    # Build the spool directory if it doesn't exist.
+    if [ ! -d ${SPOOLDIR} ] ; then
+        install -m 750 -d ${SPOOLDIR} || return 1
+    fi
+
+    adduser --system --group --no-create-home --quiet \
         --disabled-login --disabled-password \
         --shell /bin/false --home ${SPOOLDIR} ${CUSER} || return 2
 
+    # Change spool directory permissions now that clamsmtp user is created.
+    chown ${CUSER}:${CGROUP} ${SPOOLDIR}
+
     return 0
 }
 
@@ -101,7 +114,7 @@
 
     if ! grep -qi "^${CUSER}" ${AFILE}; then
         echo "${CUSER}: root" >> ${AFILE}
-        newal=`which newaliases`
+        newal=`which newaliases` || true
         if [ $newal ] && [ -x $newal ]; then
             newaliases || return 2
         fi

Finally, I did a README.source for updating to 3.8.0.  I've attached that for 
your use if you're interested.

Scott K


-------------- next part --------------
This package was debianized by Chad Walstrom <chewie at debian.org> on
Thu, 26 Aug 2004 13:28:56 -0500.

It was downloaded from http://memberwebs.com/nielsen/software/clamsmtp/

The location has been updated to http://memberwebs.com/stef/

Upstream Author: Stefan Walter <stef at memberwebs.com> also known as Nate Nielsen
                 <nielsen at memberwebs.com>

Copyright (c) 2004-2005, Stefan Walter/Nate Nielsen
All rights reserved.

Redistribution and use in source and binary forms, with or without modification,
are permitted provided that the following conditions are met:

    * Redistributions of source code must retain the above copyright notice,
    * this list of conditions and the following disclaimer.
    * Redistributions in binary form must reproduce the above copyright notice,
    * this list of conditions and the following disclaimer in the documentation
    * and/or other materials provided with the distribution.
    * The names of contributors to this software may not be used to endorse or
    * promote products derived from this software without specific prior written
    * permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Portions of common/compat.c:
 *
 * Copyright (c) 1998 Todd C. Miller <Todd.Miller at courtesan.com>
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 * 1. Redistributions of source code must retain the above copyright
 *    notice, this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright
 *    notice, this list of conditions and the following disclaimer in the
 *    documentation and/or other materials provided with the distribution.
 * 3. The name of the author may not be used to endorse or promote products
 *    derived from this software without specific prior written permission.
 *
 * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
 * INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
 * AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL
 * THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
 * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */

-------------- next part --------------
#
# watch -- uscan config file for clamsmtp
#
# Because I manage this package with tla-buildpackage, I do not want uupdate
# stomping all over my working directory.  No action is taken.
#
version=2
http://memberwebs.com/stef/software/clamsmtp/ clamsmtp-([\w+\d+\.]+|\d+)\.tar\.gz debian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: README.source
Type: text/x-readme
Size: 254 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-clamav-devel/attachments/20081117/e4a2a717/attachment.bin

More information about the Pkg-clamav-devel mailing list