<div dir="auto"><div>Hi Christopher, <div dir="auto"><br></div><div dir="auto">thanks for your work on the flickrnet package. But I got curious why you renamed the pc file and the cil-dev package name. You mention the CLI policy section for the change so I checked the section.</div><div dir="auto"><br></div><div dir="auto">Your change is following the policy, but I noticed policy is not in line of the current practice. </div><div dir="auto"><br></div><div dir="auto">Sorry about the outdated policy. I will look into updating the policy for the pc file naming and cil-dev package naming. </div><div dir="auto"><br></div><div dir="auto">Following the ABI version in pc was making sense back then as we were not separating the pc file from the package that contains the dll. </div><div dir="auto"><br></div><div dir="auto">Mirco </div><br><div class="gmail_extra"><br><div class="gmail_quote">On Apr 19, 2017 7:42 PM, "Christopher Stuart Hoskin" <<a href="mailto:mans0954@moszumanska.debian.org">mans0954@moszumanska.debian.org</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is an automated email from the git hooks/post-receive script.<br>
<br>
mans0954 pushed a commit to branch master<br>
in repository flickrnet.<br>
<br>
commit 7f0c805fcb1d91bdcb6925c2b22134<wbr>a22831026e<br>
Author: Christopher Hoskin <<a href="mailto:christopher.hoskin@gmail.com">christopher.hoskin@gmail.com</a>><br>
Date: Wed Apr 19 12:19:06 2017 +0100<br>
<br>
Rename VERSION variable DEB_CLI_ABI_VERSION in debian/rules<br>
---<br>
debian/changelog | 1 +<br>
debian/flickrnet.pc | 4 ++--<br>
debian/rules | 18 +++++++++---------<br>
3 files changed, 12 insertions(+), 11 deletions(-)<br>
<br>
diff --git a/debian/changelog b/debian/changelog<br>
index 24587a1..f8c67fe 100644<br>
--- a/debian/changelog<br>
+++ b/debian/changelog<br>
@@ -13,6 +13,7 @@ flickrnet (1:3.24+dfsg-1) UNRELEASED; urgency=medium<br>
* Update homepage and versioned dependencies in debian/control<br>
* Bump Standards Version from 3.9.2 to 3.9.8 (no change necessary)<br>
* Include ABI version in .pc filename in accordance with CLI Policy 3.2.4<br>
+ * Rename VERSION variable DEB_CLI_ABI_VERSION in debian/rules<br>
<br>
-- Christopher Hoskin <<a href="mailto:mans0954@debian.org">mans0954@debian.org</a>> Mon, 17 Apr 2017 18:12:06 +0100<br>
<br>
diff --git a/debian/flickrnet.pc b/debian/flickrnet.pc<br>
index 1fae161..5b47b1d 100644<br>
--- a/debian/flickrnet.pc<br>
+++ b/debian/flickrnet.pc<br>
@@ -3,5 +3,5 @@ libdir=${prefix}/lib<br>
<br>
Name: flickrnet<br>
Description: Flickr.Net API Library<br>
-Version: @VERSION@<br>
-Libs: -r:${libdir}/cli/FlickrNet-@<wbr>VERSION@/FlickrNet.dll<br>
+Version: @DEB_CLI_ABI_VERSION@<br>
+Libs: -r:${libdir}/cli/FlickrNet-@<wbr>DEB_CLI_ABI_VERSION@/<wbr>FlickrNet.dll<br>
diff --git a/debian/rules b/debian/rules<br>
index f402271..a745074 100755<br>
--- a/debian/rules<br>
+++ b/debian/rules<br>
@@ -14,7 +14,7 @@<br>
#export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed<br>
<br>
#Keep version as 2.2 until we determine the correct version<br>
-VERSION=2.2<br>
+DEB_CLI_ABI_VERSION=2.2<br>
DEB_DESTDIR=debian/tmp<br>
<br>
%:<br>
@@ -25,16 +25,16 @@ override_dh_auto_build:<br>
<br>
override_dh_auto_install:<br>
#Install to debian/tmp<br>
- install -D FlickrNet/bin/Release/<wbr>FlickrNet.dll $(DEB_DESTDIR)/usr/lib/cli/<wbr>FlickrNet-$(VERSION)/<wbr>FlickrNet.dll<br>
- install -m644 -D debian/flickrnet.pc $(DEB_DESTDIR)/usr/lib/<wbr>pkgconfig/flickrnet-$(VERSION)<wbr>.pc<br>
- sed -i "s/@VERSION@/$(VERSION)/g" $(DEB_DESTDIR)/usr/lib/<wbr>pkgconfig/flickrnet-$(VERSION)<wbr>.pc<br>
-#Install to debian/libflickrnet$(VERSION)-<wbr>cil<br>
- dh_install -plibflickrnet$(VERSION)-cil $(DEB_DESTDIR)/usr/lib/cli/<wbr>FlickrNet-$(VERSION)/<wbr>FlickrNet.dll /usr/lib/cli/FlickrNet-$(<wbr>VERSION)/<br>
-#Install to debian/libflickrnet$(VERSION)-<wbr>cil-dev<br>
- dh_install -plibflickrnet$(VERSION)-cil-<wbr>dev $(DEB_DESTDIR)/usr/lib/<wbr>pkgconfig/flickrnet-$(VERSION)<wbr>.pc /usr/lib/pkgconfig/<br>
+ install -D FlickrNet/bin/Release/<wbr>FlickrNet.dll $(DEB_DESTDIR)/usr/lib/cli/<wbr>FlickrNet-$(DEB_CLI_ABI_<wbr>VERSION)/FlickrNet.dll<br>
+ install -m644 -D debian/flickrnet.pc $(DEB_DESTDIR)/usr/lib/<wbr>pkgconfig/flickrnet-$(DEB_CLI_<wbr>ABI_VERSION).pc<br>
+ sed -i "s/@DEB_CLI_ABI_VERSION@/$(<wbr>DEB_CLI_ABI_VERSION)/g" $(DEB_DESTDIR)/usr/lib/<wbr>pkgconfig/flickrnet-$(DEB_CLI_<wbr>ABI_VERSION).pc<br>
+#Install to debian/libflickrnet$(DEB_CLI_<wbr>ABI_VERSION)-cil<br>
+ dh_install -plibflickrnet$(DEB_CLI_ABI_<wbr>VERSION)-cil $(DEB_DESTDIR)/usr/lib/cli/<wbr>FlickrNet-$(DEB_CLI_ABI_<wbr>VERSION)/FlickrNet.dll /usr/lib/cli/FlickrNet-$(DEB_<wbr>CLI_ABI_VERSION)/<br>
+#Install to debian/libflickrnet$(DEB_CLI_<wbr>ABI_VERSION)-cil-dev<br>
+ dh_install -plibflickrnet$(DEB_CLI_ABI_<wbr>VERSION)-cil-dev $(DEB_DESTDIR)/usr/lib/<wbr>pkgconfig/flickrnet-$(DEB_CLI_<wbr>ABI_VERSION).pc /usr/lib/pkgconfig/<br>
<br>
override_dh_link:<br>
- dh_link -plibflickrnet$(VERSION)-cil-<wbr>dev /usr/lib/pkgconfig/flickrnet-$<wbr>(VERSION).pc /usr/lib/pkgconfig/flickrnet.<wbr>pc<br>
+ dh_link -plibflickrnet$(DEB_CLI_ABI_<wbr>VERSION)-cil-dev /usr/lib/pkgconfig/flickrnet-$<wbr>(DEB_CLI_ABI_VERSION).pc /usr/lib/pkgconfig/flickrnet.<wbr>pc<br>
dh_link<br>
<br>
override_dh_auto_clean:<br>
<font color="#888888"><br>
--<br>
Alioth's /usr/local/bin/git-commit-<wbr>notice on /srv/<a href="http://git.debian.org/git/pkg-cli-libs/packages/flickrnet.git" rel="noreferrer" target="_blank">git.debian.org/git/pkg-<wbr>cli-libs/packages/flickrnet.<wbr>git</a><br>
<br>
______________________________<wbr>_________________<br>
Pkg-cli-libs-commits mailing list<br>
<a href="mailto:Pkg-cli-libs-commits@lists.alioth.debian.org">Pkg-cli-libs-commits@lists.<wbr>alioth.debian.org</a><br>
<a href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-cli-libs-commits" rel="noreferrer" target="_blank">http://lists.alioth.debian.<wbr>org/cgi-bin/mailman/listinfo/<wbr>pkg-cli-libs-commits</a><br>
</font></blockquote></div><br></div></div></div>