Bug#601957: pending NMU

[Serafeim Zanikolas]

tag 601957 - pending
tag 601957 patch
thanks

Hi Desmond,

On Sat, Nov 06, 2010 at 03:22:17PM +0800, Desmond O. Chang wrote [edited]:
> Is it a reasonable patch for the conffile conflict?  I think it will
> delete the file even if user has modified it.

6.17 (lenny release) creates /etc/lisp-config.lisp in the postinst with a
"auto-generated, please don't modify" header, just like the pending NMU.

Digging a bit deeper though, I see that /etc/lisp-config.lisp was
intentionally shipped as a conffile in 7.0 (commit abdc1c8f) to fix wishlist
bug #518605, which however introduces this RC bug.

So the NMU is OK for lenny, but not for testing and sid, and it defeats the
intention in 7.0. I'll therefore dcut my NMU.

I think the ideal instead would be to keep lisp-confifg.lisp as a conffile,
but remove it in preinst when upgrading from versions prior to 7.0. Here's an
untested patch:

--- a/debian/common-lisp-controller.preinst	2010-07-31 02:29:24.000000000 +0200
+++ b/debian/common-lisp-controller.preinst	2010-11-06 11:02:00.000000000 +0100
@@ -23,6 +23,12 @@ case "$1" in
                 --disabled-password --disabled-login --group cl-builder 
     ;;
     upgrade)
+        # lisp-config.lisp is shipped as a conffile from 7.0 onwards, so when
+        # upgrading from earlier versions we have to remove the old
+        # auto-generated file, to avoid config file conflict (#601957)
+        if dpkg --compare-versions $2 lt 7.0; then
+            rm -f /etc/lisp-config.lisp
+        fi
         # cleanup fasl files:
         find  /usr/share/common-lisp/source/defsystem \
 	      /usr/share/common-lisp/source/asdf \

Cheers,
Serafeim