RFS: abcl

[Darren Hoo]

Hi Christoph,

On Thu, Jan 6, 2011 at 8:43 PM, Christoph Egger <christoph at debian.org> wrote:
> Darren Hoo <darren.hoo at gmail.com> writes:
>> dget http://mentors.debian.net/debian/pool/main/a/abcl/abcl_0.23.1-2.dsc

updated :

dget http://mentors.debian.net/debian/pool/main/a/abcl/abcl_0.23.1-3.dsc

> P: abcl source: debian-control-has-unusual-field-spacing line 11
> P: abcl source: debian-control-has-unusual-field-spacing line 27
>
>    Extra spaces at the begining of the Depends Fields.
>    Honestly, I don't care about these
  fixed

> I: abcl: arch-dep-package-has-big-usr-share 8187kB 99%
> I: abcl-source: arch-dep-package-has-big-usr-share 4376kB 100%
>
>    Any reason these packages are architecture specific? Both of them
>    look like the same binary would work on any architecture.
  fixed

> I: abcl: hyphen-used-as-minus-sign usr/share/man/man1/abcl.1.gz:31
> I: abcl: hyphen-used-as-minus-sign usr/share/man/man1/abcl.1.gz:32
> I: abcl: hyphen-used-as-minus-sign usr/share/man/man1/abcl.1.gz:50
>    Should be easy to fix, right? btw have you sent your manpage upstream?

  also fixed, since it's trivial I have not sent it to upstream yet.

> I: abcl: package-contains-empty-directory usr/share/doc/abcl/examples/google-app-engine/src/META-INF/
> I: abcl: package-contains-empty-directory usr/share/doc/abcl/examples/google-app-engine/war/WEB-INF/classes/META-INF/
> I: abcl: package-contains-empty-directory usr/share/doc/abcl/examples/google-app-engine/war/WEB-INF/classes/abcl_ae/
> I: abcl: package-contains-empty-directory usr/share/doc/abcl/examples/google-app-engine/war/WEB-INF/lib/
> I: abcl: package-contains-empty-directory usr/share/doc/abcl/examples/google-app-engine/war/fasls/
>
>    These look like it might actually right to keep it the way it
>    already is.
so I'll leave this as it is.

> W: abcl-source: extra-license-file usr/share/abcl-source/LICENSE
>
>    Just delete that after dh_install -- the content is already in
>    debian/copyright
>
fixed

> Other notes
> ~~~~~~~~~~~
>
> Looks quite well actually. Just the hint to abcl-source in abcl's
> description looks a bit misplaced.
>
I replace it with Suggests: abcl-source, slime

Regards
  Darren