[Pkg-cryptsetup-devel] Bug#430158: Bug#430158: Bug#430158: closed by Jonas Meurer <jonas at freesources.org> (closing because of inactivity)

[David Härdeman]

On Sat, Feb 16, 2008 at 08:31:36PM +0100, Jonas Meurer wrote:
>On 16/02/2008 Helmut Grohne wrote:
>> Hi,
>> 
>> > sorry, forgot to actually attach the patch. here it is.
>> 
>> May I propose a different patch and try that instead?
>
>sure ;-)
>
>> The retry management basically happened below in the previous version:
>> Line 181:
>> 	count=0
>> 	while [ $count -lt 3]; do
>> 
>> I therefore suggest to reuse that management (or throw it away
>> completely), because your patch will only allow for multiples of 3 tries
>> this way.
>> 
>> My patch is attached (really, no second mail :-p). If you like to use
>> the trial management from cryptsetup, it would be great if you could
>> clean the cryptroot script and send me a new patch.
>
>I'm fine with using your patch as long as David has no objections. He's
>the one who implemented initramfs stuff in the first place, so I leave
>this decision up to him. Did you already try whether your patch works?

Helmut's patch is better because it will work with the usplash stuff as 
well (and the cryptsetup --tries option doesn't). Feel free to commit it 
once you have confirmation that it works.

-- 
David Härdeman