[Pkg-cups-devel] Bug#374599: cupsys: force-reload in init.d kills the daemon (so does log rotation)

[Jean-Christophe Dubacq]

Package: cupsys
Version: 1.2.1-2
Severity: important
Tags: patch

The start-stop-daemon invokation for force-reload in /etc/init.d/cupsys
reads this way:
start-stop-daemon --stop --quiet --pidfile $PIDFILE --name $NAME --signal 1

Which means, according to the manual, to
- send signal 1 (sighup) (which reloads cups fine)
- wait five seconds
- see that cups is not dead (obviously), send sigkill signal
- wait five seconds
- see that cups is dead, be happy.

Obviously, this is not what is meant by the line.

So either --retry 5 should be removed from the line (so that sigkill
does not come into play), or the attached patch applied (this patch
just sends one sighup).

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16-1-686-smp
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)

Versions of packages cupsys depends on:
ii  adduser                  3.87            Add and remove users and groups
ii  debconf [debconf-2.0]    1.5.2           Debian configuration management sy
ii  gs-esp                   8.15.1.dfsg.1-2 The Ghostscript PostScript interpr
ii  libacl1                  2.2.37-1        Access control list shared library
ii  libc6                    2.3.6-15        GNU C Library: Shared libraries
ii  libcupsimage2            1.2.1-2         Common UNIX Printing System(tm) - 
ii  libcupsys2               1.2.1-2         Common UNIX Printing System(tm) - 
ii  libdbus-1-2              0.61-6          simple interprocess messaging syst
ii  libgnutls13              1.3.5-1.1       the GNU TLS library - runtime libr
ii  libldap2                 2.1.30-13       OpenLDAP libraries
ii  libpam0g                 0.79-3.1        Pluggable Authentication Modules l
ii  libpaper1                1.1.18          Library for handling paper charact
ii  libslp1                  1.2.1-5         OpenSLP libraries
ii  lsb-base                 3.1-10          Linux Standard Base 3.1 init scrip
ii  patch                    2.5.9-4         Apply a diff file to an original
ii  perl-modules             5.8.8-6         Core Perl modules
ii  procps                   1:3.2.6-2.2     /proc file system utilities
ii  xpdf-utils [poppler-util 3.01-8          Portable Document Format (PDF) sui
ii  zlib1g                   1:1.2.3-11      compression library - runtime

Versions of packages cupsys recommends:
ii  cupsys-client           1.2.1-2          Common UNIX Printing System(tm) - 
ii  foomatic-filters        3.0.2-20060530-1 linuxprinting.org printer support 
pn  smbclient               <none>           (no description available)

-- debconf-show failed
-------------- next part --------------
--- /tempo/chantilly/computed/ebene/etc/init.d/cupsys	2006-06-05 15:49:59.000000000 +0200
+++ /etc/init.d/cupsys	2006-06-20 08:28:25.000000000 +0200
@@ -36,7 +36,9 @@
 	;;
   reload|force-reload)
 	log_begin_msg "Reloading $DESC: $NAME"
-	start-stop-daemon --stop --quiet --pidfile $PIDFILE --name $NAME --signal 1
+	if [ -r $PIDFILE ]; then
+	  kill -1 $(cat $PIDFILE)
+	fi
 	log_end_msg $?
 	;;
   restart)