[Pkg-cups-devel] Bug#397833: /usr/lib/cups/backend-available/snmp: programming error in snmp.c

[Jochen Voss]

Package: cupsys
Version: 1.2.5-1
Severity: normal
File: /usr/lib/cups/backend-available/snmp

Hello,

recently I came across the following bit of code in the source file
cupsys-1.2.6/backend/snmp.c (function probe_device, around line 1755):

    if (http);
    {
     /*
      * IPP is supported...
      */
      ...
    }

It looks like the bracketed block is ment to be conditional on the
value of 'http'.  But since there is this strange semicolon at the end
of the line with the 'if', the block is executed unconditionally.
I think that this is a bug and that the semicolon should be removed.

I did not check in any way what the implications of the bug are, but
probably this is worth fixing anyway.

I hope this helps,
Jochen

-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18.1
Locale: LANG=en_GB.iso885915, LC_CTYPE=en_GB.iso885915 (charmap=ISO-8859-15)

Versions of packages cupsys depends on:
ii  adduser                  3.99            Add and remove users and groups
ii  cupsys-common            1.2.5-1         Common UNIX Printing System(tm) - 
ii  debconf [debconf-2.0]    1.5.8           Debian configuration management sy
ii  gs-esp                   8.15.3.dfsg.1-1 The Ghostscript PostScript interpr
ii  libc6                    2.3.6.ds1-8     GNU C Library: Shared libraries
ii  libcupsimage2            1.2.5-1         Common UNIX Printing System(tm) - 
ii  libcupsys2               1.2.5-1         Common UNIX Printing System(tm) - 
ii  libdbus-1-3              0.94-1          simple interprocess messaging syst
ii  libgnutls13              1.4.4-2         the GNU TLS library - runtime libr
ii  libldap2                 2.1.30-13.1     OpenLDAP libraries
ii  libpam0g                 0.79-4          Pluggable Authentication Modules l
ii  libpaper1                1.1.20          Library for handling paper charact
ii  libslp1                  1.2.1-6         OpenSLP libraries
ii  lsb-base                 3.1-19          Linux Standard Base 3.1 init scrip
ii  patch                    2.5.9-4         Apply a diff file to an original
ii  perl-modules             5.8.8-6.1       Core Perl modules
ii  procps                   1:3.2.7-3       /proc file system utilities
ii  xpdf-utils [poppler-util 3.01-9          Portable Document Format (PDF) sui
ii  zlib1g                   1:1.2.3-13      compression library - runtime

Versions of packages cupsys recommends:
ii  cupsys-client           1.2.5-1          Common UNIX Printing System(tm) - 
ii  foomatic-filters        3.0.2-20061031-1 linuxprinting.org printer support 
pn  smbclient               <none>           (no description available)

-- debconf information excluded