[Pkg-cups-devel] 60_device_uri.dpatch purpose?

Martin Pitt mpitt at debian.org
Sat Sep 6 12:19:15 UTC 2008


Hi Kenshi,

I'm currently working on cleaning up all the cups patches. I wondered
about this one, the purpose is not clear to me:

  * 60_device_uri: preserve old URI during the printer configuration on
    Web interface.

## 60_device_uri.dpatch by Kenshi Muto <kmuto at debian.org>
--- cups-1.2.1~/cgi-bin/admin.c 2006-07-19 04:25:44.000000000 +0000
+++ cups-1.2.1/cgi-bin/admin.c  2006-07-19 04:27:50.000000000 +0000
@@ -691,7 +691,7 @@
       * Set the current device URI for the form to the old one...
       */
 
-      if (strncmp(attr->values[0].string.text, var, strlen(var)) == 0)
+      /* if (strncmp(attr->values[0].string.text, var, strlen(var)) == 0) */
        cgiSetVariable("DEVICE_URI", attr->values[0].string.text);
     }

Do you have some more details on this? If so, can you please explain
them here, or even better, file an upstream STR about the bug, so that
the fix can go upstream?

Thank you!

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-cups-devel/attachments/20080906/f4f3ea69/attachment.pgp 


More information about the Pkg-cups-devel mailing list