[Pkg-Cyrus-imapd-Debian-devel] Bug#347660: please look at the wildcard-deactivating patches (Kolab)

[Steffen Joeris]

Package: cyrus22-imapd
Severity: wishlist
Tags: patch

Hi

Enclosed you find the patch from Kolab upstream which disabled some
checkings.
This is necessary because Kolab uses the whole email adress for the
mailbox and there are for example '%' 's :)

We know that it will be very difficult or maybe impossible to integrate it
into the official cyrus package, but i think we will discuss it
at the thread on the ML's.
Now please look at the patch so you can see it ;)

Greetings
Steffen


Code:

--- cyrus22-imapd-2.2.12/imap/imapd.c.orig      2006-01-02 14:00:49.000000000 +0100
+++ cyrus22-imapd-2.2.12/imap/imapd.c   2006-01-02 14:01:36.000000000 +0100
@@ -3923,10 +3923,12 @@
        }
     }

+  #ifdef notdef
     /* verify that the mailbox doesn't have a wildcard in it */
     for (p = oldmailboxname; !r && *p; p++) {
        if (*p == '*' || *p == '%') r = IMAP_MAILBOX_BADNAME;
     }
+  #endif

     /* attempt to rename the base mailbox */
     if (!r) {

--- cyrus-imapd-2.2.12/imap/mboxlist.c.orig     2006-01-02 14:09:58.000000000 +0100
+++ cyrus-imapd-2.2.12/imap/mboxlist.c  2006-01-02 14:10:49.000000000 +0100
@@ -476,10 +476,12 @@
                free(acl);
                return IMAP_PERMISSION_DENIED;
            }
+ #ifdef notdef
            /* disallow wildcards in userids with inboxes. */
            if (strchr(mbox, '*') || strchr(mbox, '%') || strchr(mbox, '?')) {
                return IMAP_MAILBOX_BADNAME;
            }
+ #endif

            /*
             * Users by default have all access to their personal mailbox(es),
--- cyrus-imapd-2.2.12/imap/mboxname.c.orig     2006-01-02 14:22:32.000000000 +0100
+++ cyrus-imapd-2.2.12/imap/mboxname.c  2006-01-02 14:24:02.000000000 +0100
@@ -649,8 +649,13 @@
 /*
  * Apply site policy restrictions on mailbox names.
  * Restrictions are hardwired for now.
- */
+
+ * original definition
 #define GOODCHARS " +,-.0123456789:=@ABCDEFGHIJKLMNOPQRSTUVWXYZ_abcdefghijklmnopqrstuvwxyz~"
+ */
+
+#define GOODCHARS " #$%'()*+,-.0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[]^_`abcdefghijklmnopqrstuvwxyz{|}~"
+
 int mboxname_policycheck(char *name)
 {
     unsigned i;


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15-1-686
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)