Bug#489558: cyrus-doc-2.2: bashism in /bin/sh script

[Raphael Geissert]

severity 489558 normal
thanks

2008/7/17 Sven Mueller <sven at debian.org>:
> Package cyrus-doc-2.2
> Severity 489558 wishlist
> thanks
>
> Raphael Geissert schrieb:
>>
>> Package: cyrus-doc-2.2
>> Severity: important
>> Version: 2.2.13-14
>> User: debian-release at lists.debian.org
>> Usertags: goal-dash
>>
>> While performing an archive wide checkbashisms (from the 'devscripts'
>> package) check I've found your package containing one or more /bin/sh
>> scripts making use of bashisms.
>>
>> checkbashisms' output:
>>>
>>> possible bashism in ./usr/share/doc/cyrus-doc-2.2/examples/mboxtocyrus
>>> line
>>> 57 (should be 'b = a'): if [ "$MAILBOX" == "" ]; then
>>> possible bashism in ./usr/share/doc/cyrus-doc-2.2/examples/mboxtocyrus
>>> line
>>> 61 (should be 'b = a'): if [ "$CYRUSFOLDER" == "" ]; then
>
> Note two things here:
>
> 1) This is a _possible_ bashisms.

It *IS*, checkbashisms sometimes display false positives and thus the
'possible' part comes in.

> I'm not sure wether it really is one or
> not. All instances of [ (aka. test) I tried (bash, tcsh, dash) supported the
> syntax used.

on bash it does work (_bash_ism), tcsh is out of topic as it isn't a
sh interpreter, and dash does *not* support that syntax.
Not being and expert in a subject isn't bad, but I wouldn't state such
a thing when either testing or reading say that the usage of == *is*
not required by SuSv3 (and thus policy) and *is* a bashism and does
*not* work in dash (thus affecting the release goal).

>
> 2) This is an example script in a doc package, which is unlikely to work
>  unmodified on any package users system anyway.
>
> Severity important  is therefor highly exagerated.
>
> I won't be marking this as wontfix for now, but I intend to do so.

Upgrading to normal because it is an example in a -doc package so they
are sometimes used by the users. And you being the package maintainer
I would expect you to know that the script does work unmodified when
/bin/sh links to bash.

>
> Please check your bug reports before marking them with such a high severity.

Filing and checking over 160 reports means a lot of work (several
hours), so I might indeed have missed to lower the severity of some of
the reports.

>
> Thanks.
>
> Sven
>

Cheers,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html