Cyrus Debian patches - isdigit

[Henrique de Moraes Holschuh]

(Cc to the Debian Cyrus-imap devel ML added)

On Mon, 14 Dec 2009, Bron Gondwana wrote:
> I was just reading through your cyrus-2.3 packages in experimental
> because our current install process is to build a .tar.gz and then
> use alien to convert it to a .deb, which is pretty evil.  I'd
> prefer to build real Debian packages at some point!

Heh, those packages need a lot of love.  I have some fixes, and the other
two maintainers might have a few of their own as well.  As the kernel merge
window closes, I will shift some of my spare time from kernel-land to
Debian-land, so I hope to commit a few cleanups to the experimental branch
soon.

We have an SVN tree that has much newer stuff than the packages in
experimental, this URL will help you keep better track of the packages:

http://packages.qa.debian.org/c/cyrus-imapd-2.3.html

> Anyway, I noticed that you're patching cyrus_isdigit back to isdigit
> in the sources, and wondered why.  We originally replaced those calls
> because we found that isdigit was calling out to a utf-8 enabled
> library that caused a much more complex check than is required.  It's

I don't really know, as I didn't author that patch.  But I will make sure we
don't do that in the next round of uploads.

> actually parsing numbers which are guaranteed to only include [0-9],
> and the CPU usage was halved for SEEN-db intensive workloads when we
> made this change.  The test really isn't for a fully-formed "unicode
> digit", it's for 0-9.  I'd be happy to rename it cyrus_is0to9 or
> something instead if that made the intent clearer!  We really don't
> care if it's any other sort of "digit".

I'd support that rename :-)  If 0to9 is too ugly, call it is_asciidigit() or
somesuch, that should give anyone looking at the code the hint :)

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh