19-fix_tls_ssl.dpatch

[Henrique de Moraes Holschuh]

On Wed, 23 Jun 2010, Patrick Goetz wrote:
> Hookay, I've mostly been able to confirm the validity of existing
> patches up to this point, but this one (19-fix_tls_ssl.dpatch) is
> taking up too much time so I'm looking for a little help in order to
> move on. Also, most of these patches will need some additional
> documentation anyway.
> 
> Can someone take a look and tell me what issue this patch is
> addressing?  Part of it is just fleshing out syslog error messaging,
> but this change is not clear to me:
> 
> -static void apps_ssl_info_callback(SSL * s, int where, int ret)
> +static void apps_ssl_info_callback(const SSL * s, int where, int ret)
> 

It is telling the compiler that any change to s is a bug.  Probably to get
some version of gcc to shut up about incompatible pointer types.

Check if any of the caller sites pass a const * as the first parameter.  If
any of them does, the patch is needed.

If nothing in apps_ssl_info_callback should modify s, the patch is a good
idea anyway.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh