Bug#685263: cyrus-common: Misleading(?) message on missing /run/cyrus/lock and /run/cyrus/proc

[Pawel Tomulik]

Package: cyrus-common
Version: 2.4.16-1
Severity: normal

Dear Maintainer,

This happen after fresh install, during startup. I've tried restarting master
daemon several times and it still happens.

The init script /etc/init.d/cyrus-imapd outputs (misleading?) messages:

root at myhost:~# service cyrus-imapd start
find: `/run/cyrus/lock': No such file or directory
find: `/run/cyrus/proc': No such file or directory

I currently applied a patch on my machine to suppress the mesasge (see below).

It seems, however, like the lines (I've found) had no use in the init script
(the '-delete' flags were commented out, and stdout from the function
didn't seem to be used).

To suppress the message, I applied the following patch:

======================================

--- old/cyrus-imapd	2012-08-19 00:20:40.000000000 +0200
+++ new/cyrus-imapd	2012-08-19 00:24:33.000000000 +0200
@@ -145,8 +145,8 @@
     #   2 if daemon could not be started
     
     # Clean stale entries
-    find "$LOCK_DIR" -mindepth 1 -depth -size 0 # -delete
-    find "$PROC_DIR" -mindepth 1 -depth -name '[0-9]*' # -delete
+    find "$LOCK_DIR" -mindepth 1 -depth -size 0 2> /dev/null # -delete
+    find "$PROC_DIR" -mindepth 1 -depth -name '[0-9]*' 2> /dev/null # -delete
 
     start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON --test > /dev/null \
 	|| return 1

=======================================

Are there commands supposed to be used or removed from init script?
The evemtual output from the script is also not so usefull: I've made
following test:

root at myhost:~# mkdir /run/cyrus/lock
root at myhost:~# touch /run/cyrus/lock/1123
root at myhost:~# service cyrus-imapd restart
[....] Restarting Cyrus IMAPd: cyrmaster/run/cyrus/lock/1123
/run/cyrus/lock/foo
.. ok 

Maybe it would be better, to print some informative message to the user,
about potentialy stale entries?

With best regards,

Pawel Tomulik


-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.27-grsec-xenguest1 (SMP w/1 CPU core)
Locale: LANG=pl_PL.UTF-8, LC_CTYPE=pl_PL.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages cyrus-common depends on:
ii  adduser                3.113+nmu3
ii  db-util                5.1.6
ii  db4.7-util             4.7.25-21
ii  db4.8-util             4.8.30-12
ii  db5.1-util             5.1.29-5
ii  debconf [debconf-2.0]  1.5.44

cyrus-common recommends no packages.

cyrus-common suggests no packages.

-- Configuration Files:
/etc/init.d/cyrus-imapd changed [not included]

-- debconf information excluded