bug 327479 is not fixed

[Andreas Metzler]

On 2006-10-21 "Roberto C. Sanchez" <roberto at connexer.com> wrote:
> On Sat, Oct 21, 2006 at 10:35:53AM +0200, Andreas Metzler wrote:
> > debian/changelog says:
 
> >   * Added symbol versioning for shared libraries (Closes: #327479)
 
> > However: The symbol versioning code is unchanged.
> > Afaict the status of this bug has not been changed.
 
> This bug is fixed.  Run `svn diff -r60:61` in your working copy to see
> what changed.  Basically, the addition of the reautofu stuff caused the
> changes of patch 0001 to actually take effect.  That is, patch 0001
> changed the Makefile.am, which was previously not being regenerated.
> The addition of the call to automake means that the Makefile.in is
> regenerated from the Makefile.am to include the new Version target from
> the patch.  Once make is run in the actual build, the Version script is
> run as well versioning the symbols.

> If you don't believe me, then build the packages and unpack one fo the
> shared libraries and run `objdump -T /path/to/lib` and look for the
> entries with SASL2 in them.

Hello,
the bugreport is not about the fact that sasl2 does not use versioned
symbols. It is excatly the other way round. The submitter claims that
the symbol versioning breaks building on PPC64.
-----------------
Please remove the Debian-specific patch 
'debian/patches/02_versioned_symbols.diff'
which causes the ppc64 build to fail.
-----------------

debian/patches/02_versioned_symbols.diff in the sid version and
ian/patches/0001_versioned_symbols.dpatch are identical except for
context and a a added space (that is [->>$@-] {+>> $@+}):
------------------------------
{+#! /bin/sh /usr/share/dpatch/dpatch-run
## 01_versioned_symbols.dpatch by  <fabbe at debian.org>
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: Use versioned symbols for libsasl2.

@DPATCH at +}
diff [--Nru3 ./cyrus-sasl-2.1.19.dfsg1/lib/Makefile.am ../build-tree.new/cyrus-sasl-2.1.19.dfsg1/lib/Makefile.am-] {+-urNad trunk~/lib/Makefile.am trunk/lib/Makefile.am+}
--- [-./cyrus-sasl-2.1.19.dfsg1/lib/Makefile.am	2004-07-02 20:39:36.000000000 +0100-] {+trunk~/lib/Makefile.am	2006-05-29 22:52:46.000000000 +0300+}
+++ [-../build-tree.new/cyrus-sasl-2.1.19.dfsg1/lib/Makefile.am	2004-07-17 19:07:03.000000000 +0100-] {+trunk/lib/Makefile.am	2006-07-12 14:38:12.000000000 +0300+}
@@ -60,8 +60,8 @@
 lib_LTLIBRARIES = libsasl2.la
 
 libsasl2_la_SOURCES = $(common_sources) $(common_headers)
-libsasl2_la_LDFLAGS = -version-info $(sasl_version)
-libsasl2_la_DEPENDENCIES = $(LTLIBOBJS)
+libsasl2_la_LDFLAGS = -version-info $(sasl_version) -Wl,--version-script=Versions
+libsasl2_la_DEPENDENCIES = $(LTLIBOBJS) Versions
 libsasl2_la_LIBADD = $(LTLIBOBJS) $(SASL_DL_LIB) $(LIB_SOCKET) $(LIB_DOOR)
 
 if MACOSX
@@ [--92,3 +92,10-] {+-93,6 +93,13+} @@
 	[-libsasl2.la >TMP.$$ && mv TMP.$$ libsasl2.la-]
 	rm -f $@
 	ln -s .libs/$@ $@
[-+-]
 
+Versions: $(libsasl2_la_OBJECTS)
+	rm -f $@
+	echo "SASL2 {" > $@
+	echo "  global:" >> $@
+	nm $(patsubst %.lo,%.o,$(libsasl2_la_OBJECTS)) | grep " [Tt] " | cut -d" " -f3 | sed -e 's/$$/;/' [->>$@-] {+>> $@+}
+	echo "};" >> $@
{++
 $(SASL_STATIC_OBJS): linksrcs
 
 linksrcs:+}
------------------------------
cu andreas
-- 
The 'Galactic Cleaning' policy undertaken by Emperor Zhark is a personal
vision of the emperor's, and its inclusion in this work does not constitute
tacit approval by the author or the publisher for any such projects,
howsoever undertaken.                                (c) Jasper Ffforde