[pkg-dhcp-devel] Bug#609408: Bug#609408: isc-dhcp: various improvements to dhclient-script & its hooks
Andrew Pollock
apollock at debian.org
Sun Jan 9 16:42:10 UTC 2011
On Sun, Jan 09, 2011 at 10:58:23AM +0100, Peter Marschall wrote:
> Package: isc-dhcp
> Version: 4.1.1-P1-15
> Severity: normal
> Tags: patch ipv6
>
> Hi, please find attached a patch series against
> git://git.debian.org/pkg-dhcp/isc-dhcp.git
> that improve various asepcts of dhclient-scripts.
>
> Here are the highlights:
> * remove bashisms
> * DHCPv6 support (currently for Linux only)
> * convert to using iproute2's ip instead of the
> venerable ifconfig & route (Linux only)
> * add comments to improve understanding
> it took me days to understand the whole thing
> * cleanup / harmonization / code deduplication
>
> I have tested these changed scripts on 2 systems
> with DHCP & DHCPv6 and can confirm they work.
>
> These patches should also fix the following bugs:
> * 567141
> The patch in that bug was correct (but could be improved)
> * 591589
> The patch from that 591589 was incomplete:
> it did not include changes to make_resolv_conf
> and most probably
> * 275653 (at least for Linux)
> with ip instead of ifconfig the issues should be gone
>
> I am sorry for filing a separate bug, but not having a public git repo myself,
> I did not find a better way to submit all the patches in order.
> On the other hand, as this is one patch series with the patches depending on
> each other, I thought it better to have them in one common place instead of
> splitting them by bugs.
>
> Please tell me what you think of the patches and if there's a better way to
> submit patches.
>
Thank you very much for your patch. I'll look into applying this once
Squeeze has released.
More information about the pkg-dhcp-devel
mailing list