[Pkg-dia-team] Bug#748034: Declarations of function prop_desc_list_find_prop differ in const-ness

[Michael Tautschnig]

Package: dia
Version: 0.97.2-15
Usertags: goto-cc

During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
the build failed with the following error. Please note that we use our research
compiler tool-chain (using tools from the cbmc package), which permits extended
reporting on type inconsistencies at link time.

[...]
libtool: link: gcc -shared  -fPIC -DPIC  .libs/diagramdata.o .libs/layer.o .libs/geometry.o .libs/color.o .libs/dia_xml.o .libs/attributes.o .libs/text.o .libs/textline.o .libs/font.o .libs/group.o .libs/utils.o .libs/arrows.o .libs/message.o .libs/focus.o .libs/sheet.o .libs/connectionpoint.o .libs/object.o .libs/object_defaults.o .libs/connection.o .libs/orth_conn.o .libs/neworth_conn.o .libs/poly_conn.o .libs/bezier_conn.o .libs/element.o .libs/polyshape.o .libs/beziershape.o .libs/objchange.o .libs/dialogs.o .libs/widgets.o .libs/units.o .libs/dia_image.o .libs/intl.o .libs/filter.o .libs/connpoint_line.o .libs/properties.o .libs/propdesc.o .libs/proplist.o .libs/propoffsets.o .libs/propobject.o .libs/prop_basic.o .libs/prop_dict.o .libs/prop_inttypes.o .libs/prop_geomtypes.o .libs/prop_attr.o .libs/prop_text.o .libs/prop_widgets.o .libs/prop_sdarray.o .libs/propdialogs.o .libs/propregistry.o .libs/dia_dirs.o .libs/plug-ins.o .libs/paper.o .libs/boundingbox.o .libs/dynamic_obj.o .libs/create.o .libs/diatransform.o .libs/diarenderer.o .libs/diainteractiverenderer.o .libs/diagdkrenderer.o .libs/diasvgrenderer.o .libs/dia_svg.o .libs/autoroute.o .libs/parent.o .libs/render_pixmap.o .libs/diaarrowchooser.o .libs/dialinechooser.o .libs/persistence.o .libs/diaerror.o .libs/diamarshal.o .libs/debug.o .libs/prefs.o .libs/newgroup.o .libs/dialib.o .libs/diacellrendererproperty.o   -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 /usr/lib/x86_64-linux-gnu/libcairo.so -lgio-2.0 -lxml2 -lgdk_pixbuf-2.0 -lgthread-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig /usr/lib/x86_64-linux-gnu/libfreetype.so -lart_lgpl_2 -lpng -lm -lz  -O2 -Wl,-z -Wl,relro -pthread   -pthread -Wl,-soname -Wl,libdia.so -o .libs/libdia.so

file ../../lib/propdesc.c line 52: error: conflicting function declarations "prop_desc_list_find_prop"
old definition in module group file ../../lib/properties.h line 316
const struct _PropDescription * (const struct _PropDescription *, const char *)
new definition in module propdesc file ../../lib/propdesc.c line 52
struct _PropDescription * (struct _PropDescription *plist, const char *name)
make[6]: *** [libdia.la] Error 64
make[6]: Leaving directory `/srv/jenkins-slave/workspace/sid-goto-cc-dia/dia-0.97.2/dia/lib'

Observe that both the return type and the type of the first parameter lack a
const in the actual definition. This may be harmless as far as the return type
is concerned, but may point at potential problems for the parameter as the
calling function will not expect modifications to the underlying plist.

Best,
Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-dia-team/attachments/20140513/6fd942fd/attachment.sig>