[Pkg-dia-team] Bug#788727: dia: "Standard - Arc" with negative/zero curve_distance forcibly changed into "Standard - Arc" with 0.01 curve_distance

[AYANOKOUZI, Ryuunosuke]

Tags: patch

Dear maintainer,

> For "Standard - Arc" with negative curve_distance,
> the shape of the object is curved arrow on oldstable,
> while it is straight arrow on stable.
> The shape should be like a curved arrow on both versions.
> This seems to be a regression.

This regression seems to be introduced by bug number #758166 [1].

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=758166

The problem of applying the patch from #758166 to dia 0.97.3 is that...

1. Reported problem (segfault) in #758166 is not reproducible
   on current unstable amd64 distribution.
2. "Standard - Arc" with negative curve distance is also meaningful,
   but the patch forcibly makes their distance into 0.01 when it saved.
   This means that once it is saved, clockwise arrow (which has negative curve distance)
   turn into straight line and editing efficiency for clockwise arrow will be gone.

I think the regression will be fixed if you revert
fix-invalid-arc-crash-on-amd64.patch, which is correspond to #758166,
What do you think?

I recompiled dia binary package on unstable amd64 distribution by following steps.

$ apt-get source dia
$ cd dia-0.97.3/
$ quilt delete fix-invalid-arc-crash-on-amd64.patch
$ dch --nmu
$ dpkg-source --commit
$ dpkg-buildpackage -us -uc
$ su
# dpkg -i ../*.deb
# exit
$ cd ../
$ debdiff dia_0.97.3-1.dsc dia_0.97.3-1.1.dsc > dia_0.97.3-1.1.debdiff

The segfault error from using "crashdia.dia" [2] does not occur from the new package,
and "Standard - Arc" with negative curve distance keeps the shape through saving and reopening.

[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=758166;filename=crashdia.dia;msg=5

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages dia depends on:
ii  dia-common           0.97.3-1.1
ii  dia-libs             0.97.3-1.1
ii  libart-2.0-2         2.3.21-2
ii  libatk1.0-0          2.18.0-1
ii  libc6                2.21-4
ii  libcairo2            1.14.4-1
ii  libfontconfig1       2.11.0-6.3
ii  libfreetype6         2.6.1-0.1
ii  libgdk-pixbuf2.0-0   2.32.2-1
ii  libglib2.0-0         2.46.2-1
ii  libgtk2.0-0          2.24.29-1
ii  libpango-1.0-0       1.38.1-1
ii  libpangocairo-1.0-0  1.38.1-1
ii  libpangoft2-1.0-0    1.38.1-1
ii  libpng12-0           1.2.54-1
ii  libxml2              2.9.3+dfsg1-1
ii  zlib1g               1:1.2.8.dfsg-2+b1

Versions of packages dia recommends:
pn  dia-shapes   <none>
pn  gsfonts-x11  <none>

dia suggests no packages.

-- no debconf information

Regards,
Ryuunosuke Ayanokouzi
--
AYANOKOUZI, Ryuunosuke <i38w7i3 at yahoo.co.jp>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dia_0.97.3-1.1.debdiff
Type: application/octet-stream
Size: 888 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-dia-team/attachments/20151216/3901a1cb/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-dia-team/attachments/20151216/3901a1cb/attachment.sig>