[Pkg-electronics-devel] Hello list I am Bhavani Shankar and about RFS of emu8051

[Bhavani Shankar R]

On Sat, Jun 12, 2010 at 11:13 PM, أحمد المحمودي <aelmahmoudy at sabily.org>wrote:

> Hello,
>
> On Sat, Jun 12, 2010 at 10:03:29PM +0530, Bhavani Shankar R wrote:
> > I am Bhavani Shankar a 23 year old electrical engineer by profession born
> > brought up and settled in Bangalore India and since my area of interest
> is
> > electrical and electronics I would like to join the team to work on
> > electronics packages and in this regard I am trying to port emu8051 which
> is
> > a simple 8051 microcontroller emulator from ubuntu and I ve posted a RFS
> on
> > mentors.debian.net which is quoted for your kind perusal here:
> ---end quoted text---
>
>  Nice having you here ! I am not a DD, but here are my comments:
>
>  * debian/docs: There's no need to install the 'INSTALL' nor README files
>    Note that lintian gives this warning:
>    W: emu8051: package-contains-upstream-install-documentation
> usr/share/doc/emu8051/INSTALL.gz
>
>       I ll correct it and upload thanks


>  * debian/copyright: Why are you licensing the packaging work under
>    public domain ? It is better to have the packaging work under the
>    same license of the upstream project, in order to avoid legal issues
>    when you decide to introduce a patch for example to upstream code.
>
>       I ll put it under GPL-2 thanks again!


>  * debian/control: I'm not sure about your use of
>    XSBC-Original-Maintainer, I've seen your reason in the changelog, I
>    hope someone on the list would comment. Note, that it causes this
>    lintian warning:
>    W: emu8051 source: unknown-field-in-dsc original-maintainer
>
>
     I ve put a user defined field to reflect the ubuntu packager
     Refer:
     http://www.debian.org/doc/debian-policy/ch-controlfields.html#s5.7



>  * I would recommend adding a .desktop file for the emulator, and send
>    it to upstream.
>  * I'd recommend using 3.0 (quilt) source format, you won't need to do
>    any change in your package except to modify source/format file
>
>      Thanks for your review ll add a desktop file and send it upstream


Regards


-- 
Bhavani Shankar.R
https://launchpad.net/~bhavi, a proud ubuntu community  member.
What matters in life is application of mind!,
It makes great sense to have some common sense..!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-electronics-devel/attachments/20100612/9b7aece3/attachment.htm>