[Pkg-electronics-devel] Bug#757263: Bug#757263: New patch

أحمد المحمودي aelmahmoudy at users.sourceforge.net
Sun Aug 10 09:50:48 UTC 2014


On Thu, Aug 07, 2014 at 01:35:34PM -0500, Arthur Marble wrote:
> diff -Naur covered.orig/covered-0.7.10/debian/patches/clang-ftbfs.diff covered/covered-0.7.10/debian/patches/clang-ftbfs.diff 
> --- covered.orig/covered-0.7.10/debian/patches/clang-ftbfs.diff	1969-12-31 18:00:00.000000000 -0600
> +++ covered/covered-0.7.10/debian/patches/clang-ftbfs.diff	2014-08-07 13:19:49.684388142 -0500
> @@ -0,0 +1,16 @@
> +--- a/src/lxt2_read.h
> ++++ b/src/lxt2_read.h
> +@@ -47,10 +47,10 @@ typedef long off_t;
> + #include <zlib.h>
> + #endif
> + 
> +-#ifdef __GNUC__
> +-#define _LXT2_RD_INLINE inline
> +-#else
> ++#ifdef __clang__
> + #define _LXT2_RD_INLINE
> ++#else
> ++#define _LXT2_RD_INLINE inline
> + #endif
> + 
> + #define LXT2_RDLOAD "LXTLOAD | "
---end quoted text---

  Shouldn't this better be:

  #ifdef __clang__
  #define _LXT2_RD_INLINE
  #else
  # ifdef __GNUC__
  # define _LXT2_RD_INLINE inline
  # else
  # define _LXT2_RD_INLINE
  # endif
  #endif

  in order to keep upstream logic the same ?

-- 
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-electronics-devel/attachments/20140810/fa04859e/attachment.sig>


More information about the Pkg-electronics-devel mailing list