<br><br><div class="gmail_quote">2010/10/26 Scott Howard <span dir="ltr"><<a href="mailto:showard314@gmail.com">showard314@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
2010/10/24 Enrique Hernández Bello <<a href="mailto:ehbello@gmail.com" class="vt-p">ehbello@gmail.com</a>>:<br>
<div class="im">> What is the next step? :)<br>
> --<br>
> Enrique Hernández Bello<br>
><br>
<br>
</div>Hi Enrique,<br>
<br>
I'm not a DD yet, but I learned a lot from sponsors being extremely<br>
picky about my packages. Here are some comments for you to consider:<br>
<br>
1) instead of CDBS and explicitly using quilt, would you consider<br>
using source format 3.0 (quilt) and debhelper 7 [2]. It should make<br>
your debian/rules simpler. It appears that you are using source 3.0<br>
(quilt), but you still have a debian/README.source and explicitly call<br>
quilt in your debian/rules. Both of those are probably unnecessary.<br>
<br></blockquote><div><br></div><div>CDBS is comfortable. Do you think that my debian/rules will be more simple without it?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
2) in debian/rules you have this comment:<br>
# dh_fixperms and override_dh_fixperms didn't work.<br>
The reason it doesn't work is that you are not using debhelper 7 type<br>
build system, but CDBS. See [2] for how to make debhelper 7 type<br>
rules.<br>
<br></blockquote><div><br></div><div>CDBS helper calls to debhelper orders. I don't know why dh_fixperms does not work.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
3) Consider reformatting your debian/copyright to DEP-5 [3] (this is<br>
nit-picking, but good form for a new package).<br>
<br>
4) Consider formatting your patch descriptions to DEP-3 [4] (this too<br>
is nit-picking, but good form for a new package).<br>
<br></blockquote><div><br></div><div>DEP documents mentioned above are really nit-picking. Are they really useful?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
5) Since this is the first debian release of your package, I would<br>
remove all your debian/changelog entries except for:<br>
<br>
fritzing (0.4.3b-1) unstable; urgency=low<br>
<br>
* Initial release (Closes: #601230)<br>
<br></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">This is your first release, and version 0.4.3b-1 makes sense to me as<br>
the first debian packaging released.<br>
<br></blockquote><div><br></div><div>If I don't increment the release number, I can't upload it to mentors repository. What do you suggest? What is the common way to version a "pre"-release package? Perhaps adding a suffix like "~mentors1"?</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
6) I like the <a href="http://control.in" target="_blank" class="vt-p">control.in</a> and debian/rules magic to have different<br>
dependencies between debian and ubuntu. I haven't seen that before,<br>
and it prevents a diff between the two.<br>
<br></blockquote><div><br></div><div>Thanks! ;)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
7) "$ lintian --pedantic -I" is clean.<br>
<br>
<br>
Of the above comments, I think (5) is probably the most important. I<br>
suggest doing 1-4 as an exercise in "good form"<br>
<br>
[1] <a href="http://wiki.debian.org/Projects/DebSrc3.0" target="_blank" class="vt-p">http://wiki.debian.org/Projects/DebSrc3.0</a><br>
[2] <a href="http://www.debian.org/doc/maint-guide/ch-dreq.en.html#s-defaultrules" target="_blank" class="vt-p">http://www.debian.org/doc/maint-guide/ch-dreq.en.html#s-defaultrules</a><br>
[3] <a href="http://dep.debian.net/deps/dep5/" target="_blank" class="vt-p">http://dep.debian.net/deps/dep5/</a><br>
[4] <a href="http://dep.debian.net/deps/dep3/" target="_blank" class="vt-p">http://dep.debian.net/deps/dep3/</a><br>
<br>
<br>
--<br>
<div class="im">To UNSUBSCRIBE, email to <a href="mailto:debian-mentors-REQUEST@lists.debian.org" class="vt-p">debian-mentors-REQUEST@lists.debian.org</a><br>
with a subject of "unsubscribe". Trouble? Contact <a href="mailto:listmaster@lists.debian.org" class="vt-p">listmaster@lists.debian.org</a><br>
</div>Archive: <a href="http://lists.debian.org/AANLkTikJ7LZCiQBQ9kqDqj72bU+GdN77DztV7FJE7ohe@mail.gmail.com" target="_blank" class="vt-p">http://lists.debian.org/AANLkTikJ7LZCiQBQ9kqDqj72bU+GdN77DztV7FJE7ohe@mail.gmail.com</a><br>
<br>
</blockquote></div><br><br><div>-- <br>Enrique Hernández Bello<br>
</div>