[Evolution] Bug#649645: FTBFS: e-attachment.c:215:2: error: implicit declaration of function, 'g_format_size_for_display' [-Werror=implicit-function-declaration]

[peter green]

g_format_size_for_display is deprecated as it uses binary prefix calculations 
but does not use the IEC prefixes to display them. Evoloution builds with 
G_DISABLE_DEPRECATED and so FTBFS

The package also uses the deprecated G_CONST_RETURN

I see several possible fixes to this

1: switch to g_format_size, this should be trivial to do but it will change 
   behaviour so i'm not personally going to write a patch that does it. I
   will leave that judgement call to those more familiar with the package.
   The deprecated G_CONST_RETURN which would have to  be fixed somehow 
   if going down this route 
2: modify the build system to not pass G_DISABLE_DEPRECATED. I have not 
   gone down this route as I HATE fighting with build systems.
3: modify the source files that use deprecated stuff to undefine 
   G_DISABLE_DEPRECATED

I have attatched a patch implementing fix 3 (I went down this road as I
thought it would be simplest though I kinda underestimated the size of 
the issue ;) ) . If you want to use the patch then just add it to the quilt 
series.

Unfortunately even after patching the deprecation issues the package
build fails with a new issue:

> dh_install -pevolution-dev  
> cp: cannot stat `./debian/tmp/usr/share/gtk-doc': No such file or directory
> dh_install: cp -a ./debian/tmp/usr/share/gtk-doc debian/evolution-dev//usr/share/ returned exit code 1
> make: *** [binary-install/evolution-dev] Error 2
> dpkg-buildpackage: error: debian/rules binary gave error exit status 2
> root at debian:/evolution-3.0.3#

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02_enable_deprecated.patch
Type: text/x-diff
Size: 6825 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-evolution-maintainers/attachments/20111124/c397aa21/attachment.patch>