Bug#332230: marked as done (wrong distro update for
/etc/init.d/exim4 (= substitute ==))
Debian Bug Tracking System
owner at bugs.debian.org
Wed Oct 5 09:03:04 UTC 2005
Your message dated Wed, 5 Oct 2005 09:46:20 +0100
with message-id <02cf01c5c989$4206c690$eb00010a at andromeda>
and subject line Bug#332230: wrong distro update for /etc/init.d/exim4 (= substitute ==)
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 5 Oct 2005 08:31:17 +0000
>From AlberT at superalbert.it Wed Oct 05 01:31:17 2005
Return-path: <AlberT at superalbert.it>
Received: from monster.roma2.infn.it [141.108.255.100]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EN4gH-00034s-00; Wed, 05 Oct 2005 01:31:17 -0700
Received: from albert.roma2.infn.it (albert.roma2.infn.it [141.108.249.243])
by monster.roma2.infn.it (8.12.11/8.12.11) with ESMTP id j958UfbX022244
(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
Wed, 5 Oct 2005 10:30:41 +0200
Received: from albert by albert.roma2.infn.it with local (Exim 4.54)
id 1EN4fn-0007PX-GZ; Wed, 05 Oct 2005 10:30:47 +0200
Content-Type: multipart/mixed; boundary="===============1740310566=="
MIME-Version: 1.0
From: "Emiliano 'AlberT' Gabrielli" <AlberT at SuperAlberT.it>
To: Debian Bug Tracking System <submit at bugs.debian.org>
Subject: wrong distro update for /etc/init.d/exim4 (= substitute ==)
X-Mailer: reportbug 3.17
Date: Wed, 05 Oct 2005 10:30:47 +0200
Message-Id: <E1EN4fn-0007PX-GZ at albert.roma2.infn.it>
X-Virus-Scanned: clamd / ClamAV version 0.75-1, clamav-milter version 0.75c
on monster
X-Virus-Status: Clean
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
This is a multi-part MIME message sent by reportbug.
--===============1740310566==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: exim4
Version: 4.54-1
Severity: normal
last distro update (for SID) replaces a comparison operator with an
assignment one in /etc/init.d/exim4 ..
Even if the results seems to be the same this is a logical error, and so
the change should be reverted to
if [ "$(readlink /proc/$pid/root)" == "/" ]; then
Moreover I suggest to background the start_exim invocation .. this way
avoiding hanging on network problems
start_exim &
-- Package-specific info:
Exim version 4.54 #1 built 04-Oct-2005 10:01:38
Copyright (c) University of Cambridge 2005
Berkeley DB: Sleepycat Software: Berkeley DB 4.2.52: (December 3, 2003)
Support for: crypteq iconv() IPv6 GnuTLS
Lookups: lsearch wildlsearch nwildlsearch iplsearch cdb dbm dbmnz dsearch nis nis0 passwd
Authenticators: cram_md5 plaintext
Routers: accept dnslookup ipliteral manualroute queryprogram redirect
Transports: appendfile/maildir/mailstore autoreply lmtp pipe smtp
Fixed never_users: 0
Configuration file is /var/lib/exim4/config.autogenerated
# /etc/exim4/update-exim4.conf.conf
#
# Edit this file and /etc/mailname by hand and execute update-exim4.conf
# yourself or use 'dpkg-reconfigure exim4-config'
dc_eximconfig_configtype='satellite'
dc_other_hostnames='XXXX.roma2.infn.it'
dc_local_interfaces='127.0.0.1'
dc_readhost='XXXX.roma2.infn.it'
dc_relay_domains=''
dc_minimaldns='false'
dc_relay_nets=''
dc_smarthost='XXXX.roma2.infn.it'
CFILEMODE='644'
dc_use_split_config='true'
dc_hide_mailname='true'
dc_mailname_in_oh='true'
mailname:XXXX.roma2.infn.it
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (1100, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-albert
Locale: LANG=it_IT at euro, LC_CTYPE=it_IT at euro (charmap=ISO-8859-15)
Versions of packages exim4 depends on:
ii exim4-base 4.54-1 support files for all exim MTA (v4
ii exim4-daemon-light 4.54-1 lightweight exim MTA (v4) daemon
exim4 recommends no packages.
-- no debconf information
--===============1740310566==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="exim4.patch"
--- /etc/init.d/exim4.dpkg-dist 2005-10-04 11:41:03.000000000 +0200
+++ /etc/init.d/exim4 2005-09-12 09:14:46.000000000 +0200
@@ -111,7 +111,7 @@
{
SIG="${1:-TERM}"
for pid in $(pidof $NAME); do
- if [ "$(readlink /proc/$pid/root)" = "/" ]; then
+ if [ "$(readlink /proc/$pid/root)" == "/" ]; then
kill -$SIG $pid
fi
done
@@ -133,7 +133,7 @@
# regenerate exim4.conf
upex4conf
isconfigvalid
- start_exim
+ start_exim &
echo "$NAME."
;;
stop)
--===============1740310566==--
---------------------------------------
Received: (at 332230-done) by bugs.debian.org; 5 Oct 2005 08:46:53 +0000
>From debian-bts at adam-barratt.org.uk Wed Oct 05 01:46:52 2005
Return-path: <debian-bts at adam-barratt.org.uk>
Received: from mail0.avcosystems.co.uk [195.224.236.86]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EN4vM-0001O2-00; Wed, 05 Oct 2005 01:46:52 -0700
Received: from lexx.avco ([192.168.0.1] helo=andromeda)
by mail0.avcosystems.co.uk with esmtp (Exim 4.53 #1 (Debian))
id 1EN4uq-0004iH-JU; Wed, 05 Oct 2005 09:46:20 +0100
Received: from 127.0.0.1 (AVG SMTP 7.0.344 [267.11.10]); Wed, 05 Oct 2005 09:46:20 +0100
Message-ID: <02cf01c5c989$4206c690$eb00010a at andromeda>
From: "Adam D. Barratt" <debian-bts at adam-barratt.org.uk>
To: "Emiliano 'AlberT' Gabrielli" <AlberT at SuperAlberT.it>
Cc: <332230-done at bugs.debian.org>
References: <E1EN4fn-0007PX-GZ at albert.roma2.infn.it>
Subject: Re: Bug#332230: wrong distro update for /etc/init.d/exim4 (= substitute ==)
Date: Wed, 5 Oct 2005 09:46:20 +0100
MIME-Version: 1.0
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1506
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1506
X-AVCO-Scan-Signature: 39307fb75dc1305ea2a62b446e8cc53a
Delivered-To: 332230-done at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
On Wednesday, October 05, 2005 9:30 AM, Emiliano 'AlberT' Gabrielli
<AlberT at SuperAlberT.it> wrote:
> Package: exim4
> Version: 4.54-1
> Severity: normal
>
> last distro update (for SID) replaces a comparison operator with an
> assignment one in /etc/init.d/exim4 ..
No, it didn't. It replaced a non-POSIX conforming comparison operator with a
conformant comparison operator. test does not support an assignment
operator.
See http://www.opengroup.org/onlinepubs/009695399/utilities/test.html
> Even if the results seems to be the same this is a logical error, and
> so
> the change should be reverted to
>
> if [ "$(readlink /proc/$pid/root)" == "/" ]; then
>
There is no logical error, and the change should not be reverted. = and ==
have exactly the same effect, but the latter is a bash extension, and not
supported by the relevant standard (as per the URL I quoted above).
The results are the same, except that the init script now works in *all*
POSIX compliant shells, not just bash and other shells that have implemented
the extension behaviour.
Closing this report as this isn't a bug.
Regards,
Adam
More information about the Pkg-exim4-maintainers
mailing list