Bug#355749: exim4-base: conffile prompt for etch upgrade

[Justin Pryzby]

On Tue, Mar 07, 2006 at 06:59:39PM +0100, Andreas Metzler wrote:
> On 2006-03-07 Justin Pryzby <justinpryzby at users.sourceforge.net> wrote:
> > Package: exim4-base
> > Version: 4.60-4
> > Severity: important
> 
> > The attached diff was presented to me while updating exim4 from
> > version 4.60-3; I didn't make the indicated changes, so I shouldn't
> > need to be prompted about them.
> 
> I cannot reproduce this. Neither of
> fresh install of 4.50.8 --> 4.60-4
> fresh install of 4.50.8 --> 4.60-3 --> 4.60-4
> fresh install of 4.60-3 --> 4.60-4
> shows any unnecessary conffile prompts. Do you know which version you
> upgraded from? Can you reproduce this bug?
See above: 4.60-3; I just attempted to reproduce it, and failed, while
upgrading from 4.60-3 on a different machine..  Yesterdays upgrade on
a 3rd machine also had no such prompts.

> > If you're not familiar with conffile prompting issues, see my message
> > to bug #345112 and friends.
> [...]
> 
> Afaik /etc/init.d/exim4 has always been and continues to be part of
> exim4-base, therefore this is not similar to #345112.
Right; the similarity wasn't with the source of the problem (transfer
of conffile ownership), but the nearly-general agreement that conffile
prompts shouldn't happen unnecessarily, and different mechanisms by
which they can be avoided.

I'm including an interdiff of the dpkg prompt diff vs the diff between
the conffile included in the 2 relevant versions of the package; do
you recognize it?  This isn't change I would have made.

Justin
-------------- next part --------------
diff -u /etc/init.d/exim4 /etc/init.d/exim4
--- /etc/init.d/exim4	2006-01-28 09:56:53.000000000 -0500
+++ /etc/init.d/exim4	2006-03-07 14:17:30.000000000 -0500
@@ -45,7 +45,6 @@
 fi
 
 
-
 DAEMON="/usr/sbin/exim4"
 NAME="exim4"
 
@@ -113,7 +112,7 @@
 {
   SIG="${1:-TERM}"
   for pid in $(pidof $NAME); do
-    if [ "$(readlink /proc/$pid/root)" = "/" ]; then
+    if [ "$(readlink /proc/$pid/root)" == "/" ]; then
       kill -$SIG $pid
     fi
   done