Bug#887971: Clarify instructions for exim4-daemon-custom

[Gedalya]

Package: src:exim4
Version: 4.90-4

Here are some suggested improvements to the instructions in debian/rules for creating the exim4-daemon-custom package.

In my experience, calling "debian/rules pack-configs" is mandatory, and it has been this way since before the recent changes. "debian/rules clean" gets called early in the build process. See my results attached.

Thanks for maintaining this! :-)

Gedalya


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Clarify-instructions-for-exim4-daemon-custom.patch
Type: text/x-patch
Size: 1801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-exim4-maintainers/attachments/20180122/4dfe130e/attachment.bin>
-------------- next part --------------
$ dpkg-buildpackage -b
dpkg-buildpackage: info: source package exim4
dpkg-buildpackage: info: source version 4.90-4
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Andreas Metzler <ametzler at debian.org>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build exim4-4.90
 fakeroot debian/rules clean
dh clean --no-parallel
   debian/rules override_dh_auto_clean
make[1]: Entering directory '/home/jedi/exim-build/exim4-4.90'
debconf-updatepo
rm -rf build-* doc/tmp test/ b-exim*
rm -f EDITME.* unpack-configs-stamp bdir-stamp
rm -f /home/jedi/exim-build/exim4-4.90/debian/debconf/exim4.conf.template /home/jedi/exim-build/exim4-4.90/debian/files \
	/home/jedi/exim-build/exim4-4.90/debian/README.Debian /home/jedi/exim-build/exim4-4.90/debian/README.Debian.html \
	/home/jedi/exim-build/exim4-4.90/debian/berkeleydb.sed
#these are identical for all daemon-* and therefore symlinked
#pwd
chmod 755 /home/jedi/exim-build/exim4-4.90/debian/exim-gencert \
	/home/jedi/exim-build/exim4-4.90/debian/lynx-dump-postprocess /home/jedi/exim-build/exim4-4.90/debian/script \
	/home/jedi/exim-build/exim4-4.90/debian/exim-adduser /home/jedi/exim-build/exim4-4.90/debian/exim4_refresh_gnutls-params
make[1]: Leaving directory '/home/jedi/exim-build/exim4-4.90'
   dh_clean -O--no-parallel
 debian/rules build
dh build --no-parallel
   dh_update_autotools_config -O--no-parallel
   dh_autoreconf -O--no-parallel
   debian/rules override_dh_auto_configure
make[1]: Entering directory '/home/jedi/exim-build/exim4-4.90'
patch -o EDITME.eximon exim_monitor/EDITME \
	/home/jedi/exim-build/exim4-4.90/debian/EDITME.eximon.diff
patching file EDITME.eximon (read from exim_monitor/EDITME)
patch -o EDITME.exim4-light src/EDITME \
	/home/jedi/exim-build/exim4-4.90/debian/EDITME.exim4-light.diff
patching file EDITME.exim4-light (read from src/EDITME)
for editme in /home/jedi/exim-build/exim4-4.90/debian/EDITME.exim4-*.diff; do \
  if [ "$editme" != "/home/jedi/exim-build/exim4-4.90/debian/EDITME.exim4-light.diff" ]; then \
    TARGETNAME=`basename $editme .diff`; \
    echo patch -o $TARGETNAME EDITME.exim4-light $editme; \
    patch -o $TARGETNAME EDITME.exim4-light $editme || \
    exit $? ;\
  fi; \
done
patch -o EDITME.exim4-heavy EDITME.exim4-light /home/jedi/exim-build/exim4-4.90/debian/EDITME.exim4-heavy.diff
patching file EDITME.exim4-heavy (read from EDITME.exim4-light)
touch unpack-configs-stamp
for i in exim4-daemon-light exim4-daemon-heavy exim4-daemon-custom ; do \
	mkdir b-$i && \
	find . -mindepth 1 -maxdepth 1 \
	-name debian -prune -o \
	-name 'b-*' -o -print0 | \
	xargs --no-run-if-empty --null \
	cp -a --target-directory=b-$i ; \
done
touch bdir-stamp
for i in exim4-daemon-light exim4-daemon-heavy exim4-daemon-custom ; do \
	mkdir -p b-$i/Local && \
	cp EDITME.`echo $i | sed -e s/exim4-daemon/exim4/` \
	b-$i/Local/Makefile && \
	cp EDITME.eximon b-$i/Local/eximon.conf ;\
	done
cp: cannot stat 'EDITME.exim4-custom': No such file or directory
debian/rules:107: recipe for target 'override_dh_auto_configure' failed
make[1]: *** [override_dh_auto_configure] Error 1
make[1]: Leaving directory '/home/jedi/exim-build/exim4-4.90'
debian/rules:297: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2