Bug#330522: [pkg-fetchmail-maint] Bug#330522: fetchmail: don't hide errors in postinst

[Nico Golde]

Hi,
* Goswin von Brederlow <brederlo at informatik.uni-tuebingen.de> [2005-09-29 16:43]:
> Nico Golde <nico at ngolde.de> writes:
> > Hi,
> > * Goswin von Brederlow <brederlo at informatik.uni-tuebingen.de> [2005-09-29 16:13]:
> >> Nico Golde <nico at ngolde.de> writes:
> >> 
> >> > tags 330522 + pending
> >> > Hi Lars,
> >> > * Lars Wirzenius <liw at iki.fi> [2005-09-29 11:13]:
> >> >> Package: fetchmail
> >> >> Version: 6.2.5-18
> >> >> 
> >> >> The fetchmail postinst script contains the following:
> >> >> 
> >> >> adduser --system --ingroup nogroup --home /var/run/fetchmail \
> >> >>         --shell /bin/sh --disabled-password fetchmail >/dev/null 2>&1 ||
> >> >> true
> >> >> 
> >> >> 
> >> >> If the adduser command fails, this manages to hide the fact from the
> >> >> sysadmin. This is not good.
> >> >
> >> > Thanks fixed in svn.
> >> > Regards Nico
> >> 
> >> I hope you tested this. The adduser command gives some warnings when
> >> the homedir or user already exists and I think returns an error in
> >> some cases where it shouldn't. The command is for updating the user
> >> info (from older fetchmails) as well as creating the user if it
> >> doesn't exist and both cases should do so quietly.
> >
> > root at noname:/home/nion$ adduser --system --ingroup nogroup --home /var/run/fetchmail \
> >         --shell /bin/sh --disabled-password fetchmail
> > adduser: Warnung: Das von Ihnen angebene Homeverzeichnis existiert bereits.
> > The user `fetchmail' already exists as a system user. Exiting...
> > root at noname:/home/nion$ echo $?
> > 0
> 
> Yes. But now you have 2 extra lines output that should not be there.

yes but the user should be informed that something failed. i 
think that was liw's intention.
regards nico
-- 
Nico Golde - JAB: nion at jabber.ccc.de | GPG: 0x73647CFF
http://www.ngolde.de | http://www.muttng.org | http://grml.org 
$ route add default roma.it
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-fetchmail-maint/attachments/20050929/0d27537f/attachment.pgp