[pkg-fetchmail-maint] Bug#554829: init script checks for fetchmailrc existance before checking START_DAEMON variable

[Lutz Böhne]

Package: fetchmail
Version: 6.3.9~rc2-7
Severity: normal
Tags: patch

The init script included with the fetchmail package first checks whether
/etc/fetchmailrc exists and returns with an error message otherwise.

It only goes on to check whether START_DAEMON is set to yes or no in
/etc/default/fetchmail afterwards.

I think this is a bug, as the init script should only worry about
non-existing configuration files if the user wants it to
automatically start. I propose to switch the order of checks around, as
per the attached patch.


-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.30-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.utf8)
Shell: /bin/sh linked to /bin/dash

Versions of packages fetchmail depends on:
ii  adduser                  3.111           add and remove users and groups
ii  debianutils              3.2.1           Miscellaneous utilities specific t
ii  libc6                    2.9-25          GNU C Library: Shared libraries
ii  libcomerr2               1.41.9-1        common error description library
ii  libgssapi-krb5-2         1.7dfsg~beta3-1 MIT Kerberos runtime libraries - k
ii  libk5crypto3             1.7dfsg~beta3-1 MIT Kerberos runtime libraries - C
ii  libkrb5-3                1.7dfsg~beta3-1 MIT Kerberos runtime libraries
ii  libssl0.9.8              0.9.8k-5        SSL shared libraries
ii  lsb-base                 3.2-23          Linux Standard Base 3.2 init scrip

Versions of packages fetchmail recommends:
ii  ca-certificates               20090814   Common CA certificates

Versions of packages fetchmail suggests:
ii  exim4                         4.69-11    metapackage to ease Exim MTA (v4) 
ii  exim4-daemon-light [mail-tran 4.69-11+b1 lightweight Exim MTA (v4) daemon
pn  fetchmailconf                 <none>     (no description available)
ii  resolvconf                    1.45       name server information handler

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fetchmail.patch
Type: text/x-diff
Size: 926 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fetchmail-maint/attachments/20091106/df4cdf8c/attachment.patch>