[pkg-fetchmail-maint] Bug#612179: Bug#612179: resolvconf tries to awaken fetchmail even if its not running leading to failed service at boot

[Nico Golde]

Hi,
* Teodor MICU <mteodor at gmail.com> [2011-08-30 16:02]:
[...] 
> The following change does not have the intended effect:
> 
> Changes made to '/etc/resolvconf/update-libc.d/fetchmail' follow:
>   @@ -7,6 +7,6 @@
>    	shift
>    done
> 
>   -if [ -x /etc/init.d/fetchmail ]; then
>   +if [ -x /etc/init.d/fetchmail ] && [ "$(pidof fetchmail)" != "x" ]; then
>    	/etc/init.d/fetchmail awaken
>    fi
> 
> The second test will always be true. You probably wanted to add "x"
> before $()

Argl, indeed. I should've done c&p after I've tested that.

> but I recommend to avoid such a workarround and use the
> builtin test instead for non-empy string:
>   [ -n "$(pidof fetchmail)" ]
> 
> The test will return false if that command will return an empty
> string, thus fetchmail is not running. However, some other package
> maintainers have decided to rely on the return code of
> "/etc/init.d/$SRV status > /dev/null" to decide if the service should
> be restarted/reloaded.

Seems fine either way. Will be fixed in the next upload. Thanks for reopening!

Cheers
Nico
-- 
Nico Golde - http://www.ngolde.de - nion at jabber.ccc.de - GPG: 0xA0A0AAAA
For security reasons, all text in this mail is double-rot13 encrypted.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fetchmail-maint/attachments/20110830/b767f92d/attachment.pgp>