[Pkg-fonts-devel] [Pkg-fonts-commits] r3605 - in packages/fonts-cmu/trunk: . debian debian/source

[Christian PERRIER]

Some comments:


> +Package: fonts-cmu
> +Architecture: all
> +Depends: ${shlibs:Depends}, ${misc:Depends}

${shlibs:Depends} is useless for arch:all packages. Yes, I know, we
still have some packages with this in SVN..:-)

> +Description: Sets the Computer Modern Unicode fonts

Synopsis doesn't follow the Developer's Reference guidelines:

- no leading capital
- no verb sentence
- "to be improved" English..:-)

> + This package contains a set of Computer Modern Unicode fonts.
> + It provides OpenType files.

"This package *provides*" is to be preferred over "contains".

Could be shrinked to "provides a set of OpenType Computer Modern
fonts".

maybe tell more about what Unicode blocks are covered.

Think about asking to debian-l10n-english for a review of the package description.


> +Files: *
> +Copyright: 2003-2009, Andrey V. Panov (panov at canopus.iacp.dvo.ru)
> + Original meta fonts Donald Ervin Knuth (cm, concrete fonts)
> + 1995, 1996, 1997 J"org Knappen, 1990, 1992 Norbert Schwarz (ec fonts)
> + 1992-2006 A.Khodulev, O.Lapko, A.Berdnikov, V.Volovich (lh fonts)
> + 1997-2005 Claudio Beccari (cb greek fonts)
> + 2002 FUKUI Rei (tipa fonts)
> + 2003-2005 Han The Thanh (Vietnamese fonts)
> + 1996-2005 Walter Schmidt (cmbright fonts)

If copyrights varies from one font to another, then you must use
several "Files: <foo>" entries. That's what DEP-5 is about.


> +License: SIP Open Font License

s/SIP/SIL. Mention version here

> + This Font Software is licensed under the SIL Open Font License, Version 1.1.
> + This license is copied below, and is also available with a FAQ at:
> + http://scripts.sil.org/OFL
> +-----------------------------------------------------------
> +SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
> +-----------------------------------------------------------

Needs to be prepended by spaces at beginning of each line.

> --- packages/fonts-cmu/trunk/debian/rules	                        (rev 0)
> +++ packages/fonts-cmu/trunk/debian/rules	2011-08-01 10:01:11 UTC (rev 3605)
> @@ -0,0 +1,13 @@
> +#!/usr/bin/make -f
> +# -*- makefile -*-
> +# Sample debian/rules that uses debhelper.
> +# This file was originally written by Joey Hess and Craig Small.
> +# As a special exception, when this file is copied by dh-make into a
> +# dh-make output file, you may use that output file without restriction.
> +# This special exception was added by Craig Small in version 0.37 of dh-make.
> +
> +# Uncomment this to turn on verbose mode.
> +#export DH_VERBOSE=1
> +
> +%:
> +	dh $@ 


Drop comments and just use something similar to what we have in
fonts-arabeyes, for instance.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-fonts-devel/attachments/20110801/0057c813/attachment.pgp>