[Pkg-fonts-devel] Bug#772687: Bug#772687: Bug#772687: Bug#772687: Bug#772687: Bug#772687: Bug#772687: fonts-droid: fallback font is installed too early to fontconfig

[Vasudev Kamath]

Jonas Smedegaard <dr at jones.dk> writes:

> Quoting Vasudev Kamath (2014-12-29 07:13:34)
>> Norbert Preining <preining at logic.at> writes:
>> 
>> > On Sun, 28 Dec 2014, Vasudev Kamath wrote:
>> >> I've prepared the package and updated maintscript file to handle now
>> >> obsolete 65-droid-sans-fallback.conf file removal.
>> >
>> > Hmm, something is funny here ... building the package I see:
>> >
>> > for f in DroidSansFallback.ttf DroidSansFallbackLegacy.ttf ; \
>> > do \
>> >       cd debian/fonts-droid/usr/share ; \
>> >       mv fonts/truetype/droid/$f \
>> >               fonts-droid/truetype/$f || true ; \
>> > done
>> > /bin/sh: 3: cd: can't cd to debian/fonts-droid/usr/share
>> >
>> > but stil the fonts end up in /usr/share/fonts-droid/truetype/ ...
>> > One of you will know why ...
>> 
>> It looks like Christian introduced these changes to close the
>> bug#762296, I think the error message comes second time when the cd is
>> executed in for loop. It still works because with first cd we are
>> already inside the directory where fonts are present.
>> 
>> The fix is move the cd outside the for loop. I'm not sure if we have to
>> include this now or wait for after Jessie.
>
> Another fix would be to use non-relative path in the cd call.

Yeah, but moving the cd out solves this. In first place it should not be
inside the for loop.

>
> But (judging only from above comments) there might be another issue with 
> that loop not handling errors correctly.  Perhaps as simple as a "set 
> -e" (although I seem to recall that maintainer scripts shouldn't blindly 
> do that).

Yes, there should be probably a declaration

SHELL := sh -e

which would error out when anything in shell command goes wrong. But I
think its better to target this post Jessie.

-- 
Vasudev Kamath
http://copyninja.info
Connect on ~friendica: copyninja at samsargika.copyninja.info
IRC nick: copyninja | vasudev {irc.oftc.net | irc.freenode.net}
GPG Key: C517 C25D E408 759D 98A4  C96B 6C8F 74AE 8770 0B7E