[Pkg-fonts-devel] Packaging fonts-noto-cjk

[Vasudev Kamath]

ChangZhuo Chen <czchen at gmail.com> writes:

> On Sat, Nov 21, 2015 at 08:25:35PM +0530, Vasudev Kamath wrote:
>> Hi Chang,
>> 
>> ChangZhuo Chen <czchen at gmail.com> writes:
>> >
>> > Hi Vasudev,
>> >
>> > No problem, I will take care of fonts-noto-cjk.
>> >
>> Thanks!. Just ping me back here once you are done with fonts-noto-cjk so
>> it can be uploaded along side fonts-noto.
>
> Hi,
>
> The fonts-noto-cjk is ready in [0], please help to see if there is any
> problem.

Is it really tracking the upstream release?. ¹. I see a lot of fonts in
there also NotoSansCJK.ttc is in zip format. So wondering how you did
repack of upstream.

It is always good to add comment in copyright on how you repacked the
original upstream source like this. ².

Remaining things looks fine to me but I will let others nitpick :-).

¹ https://github.com/googlei18n/noto-cjk
² https://anonscm.debian.org/cgit/pkg-fonts/fonts-noto.git/commit/debian/copyright?id=0f2e394190caceee2c8d64f15ee34ef66f925496