[Pkg-freevo-maint] Bug#542089: freevo: Incorrect dependencies in init.d scripts

[Petter Reinholdtsen]

Package:  freevo
Version:  1.8.0~rc1-1
Severity: important
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d script.  The update-rc.d call said it should have
the default settings, while the dependency information in the init.d
scripts do not match this.

<URL: http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html >
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.

This patch should solve the issue.

diff -ur freevo-1.9.0/debian/freevo.freevo_encodingserver.init freevo-1.9.0-pere/debian/freevo.freevo_encodingserver.init
--- freevo-1.9.0/debian/freevo.freevo_encodingserver.init       2009-08-17 19:53:41.000000000 +0200
+++ freevo-1.9.0-pere/debian/freevo.freevo_encodingserver.init  2009-08-17 19:52:07.000000000 +0200
@@ -1,8 +1,8 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:            freevo-encodingserver
-# Required-Start: rmnologin
-# Required-Stop:
+# Required-Start:       $remote_fs $syslog
+# Required-Stop:        $remote_fs $syslog
 # Should-Start:
 # Should-Stop:
 # Default-Start:       2 3 4 5
diff -ur freevo-1.9.0/debian/freevo.freevo_recordserver.init freevo-1.9.0-pere/debian/freevo.freevo_recordserver.init
--- freevo-1.9.0/debian/freevo.freevo_recordserver.init 2009-08-17 19:53:41.000000000 +0200
+++ freevo-1.9.0-pere/debian/freevo.freevo_recordserver.init    2009-08-17 19:52:14.000000000 +0200
@@ -1,8 +1,8 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:            freevo-recordserver
-# Required-Start: rmnologin
-# Required-Stop:
+# Required-Start:       $remote_fs $syslog
+# Required-Stop:        $remote_fs $syslog
 # Should-Start:
 # Should-Stop:
 # Default-Start:       2 3 4 5
diff -ur freevo-1.9.0/debian/freevo.freevo_rssserver.init freevo-1.9.0-pere/debian/freevo.freevo_rssserver.init
--- freevo-1.9.0/debian/freevo.freevo_rssserver.init    2009-08-17 19:53:41.000000000 +0200
+++ freevo-1.9.0-pere/debian/freevo.freevo_rssserver.init       2009-08-17 19:52:17.000000000 +0200
@@ -1,8 +1,8 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:            freevo-rssserver
-# Required-Start: rmnologin
-# Required-Stop:
+# Required-Start:       $remote_fs $syslog
+# Required-Stop:        $remote_fs $syslog
 # Should-Start:
 # Should-Stop:
 # Default-Start:       2 3 4 5
diff -ur freevo-1.9.0/debian/freevo.freevo_webserver.init freevo-1.9.0-pere/debian/freevo.freevo_webserver.init
--- freevo-1.9.0/debian/freevo.freevo_webserver.init    2009-08-17 19:53:41.000000000 +0200
+++ freevo-1.9.0-pere/debian/freevo.freevo_webserver.init       2009-08-17 19:52:19.000000000 +0200
@@ -1,8 +1,8 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:            freevo-webserver
-# Required-Start: rmnologin
-# Required-Stop:
+# Required-Start:       $remote_fs $syslog
+# Required-Stop:        $remote_fs $syslog
 # Should-Start:
 # Should-Stop:
 # Default-Start:       2 3 4 5
diff -ur freevo-1.9.0/debian/freevo.freevo_xserver.init freevo-1.9.0-pere/debian/freevo.freevo_xserver.init
--- freevo-1.9.0/debian/freevo.freevo_xserver.init      2009-08-17 19:53:41.000000000 +0200
+++ freevo-1.9.0-pere/debian/freevo.freevo_xserver.init 2009-08-17 19:52:23.000000000 +0200
@@ -1,8 +1,8 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:            freevo-xserver
-# Required-Start: rmnologin
-# Required-Stop:
+# Required-Start:       $remote_fs $syslog
+# Required-Stop:        $remote_fs $syslog
 # Should-Start:
 # Should-Stop:
 # Default-Start:       2 3 4 5
diff -ur freevo-1.9.0/debian/freevo.template.init freevo-1.9.0-pere/debian/freevo.template.init
--- freevo-1.9.0/debian/freevo.template.init    2009-08-17 19:53:41.000000000 +0200
+++ freevo-1.9.0-pere/debian/freevo.template.init       2009-08-17 19:52:30.000000000 +0200
@@ -1,8 +1,8 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:            freevo- at service@
-# Required-Start: rmnologin
-# Required-Stop:
+# Required-Start:       $remote_fs $syslog
+# Required-Stop:        $remote_fs $syslog
 # Should-Start:
 # Should-Stop:
 # Default-Start:       2 3 4 5

Happy hacking,
-- 
Petter Reinholdtsen