[pkg-fso-maint] fso-frameworkd in main (was Re: Upload to main?)

[Luca Capello]

Hi there!

On Fri, 03 Oct 2008 18:09:56 +0200, Luca Capello wrote:
> On Fri, 03 Oct 2008 17:08:24 +0200, Joachim Breitner wrote:
>> patches.debian.net is a good point, and quilt is fine with me.
>
> OK, I'll then convert fso-frameworkd to quilt in this w/e, I should have
> some free time while the kernel builds...

I uploaded the new version with all the Debian-specific patches applied
either through quilt or as single files.

However, while chronologically moving through the Debian patches, I
found the following problems:

1) we still ship a modified framework/subsystems/ogsmd/gsm/channel.py
   [1], but the upstream bug has been closed [2] and since then no one
   complained upstream.

   I imported it anyway [3], but since I haven't set a PIN to access my
   SIM card and I don't have any other mobile phone with me, can someone
   confirm that SIM unlocking through PIN works with the upstream file
   [4] on Debian [5] (i.e. without the Debian patch [3], please?

2) is the logging patch for frameworkd/subsystems/ogsmd/gsm/const.py [6]
   still useful?  It doesn't do any harm and I imported it [7], but
   upstream should be noticed.

3) the Gypsy D-Bus path [8] is not yet included upstream: does Debian do
   something different from upstream, thus the need for this patch?

4) frameworkd/config.py should play well with pyton-support as well,
   thus avoiding the need for a Debian-specific patch [9].  I already
   expressed my wish for upstream to fix it [10], but no news since
   then.

The last issue preventing fso-frameworkd to be uploaded to main is the
ringtone one [11]: this *is* a show-stopper :-(

Minor issues:

a) dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be
   avoided if "[...]/framework/subsystems/odeviced/wireless.so" were not
   uselessly linked against it (they use none of its symbols)

   However, since libpthread.so.0 is provided by libc6, this is a very
   very minor issue

b) fso-frameworkd source: debian-watch-file-is-missing
   [...]
   Refer to Debian Policy Manual section 4.11 (Optional upstream source
   location: debian/watch) and the uscan(1) manual page for details.

   If we want to shut lintian down, we need an empty debian/watch file.

c) fso-frameworkd source: patch-system-but-direct-changes-in-diff .gbp.conf

   I'd remove the 'builder' line in .gbp.conf because of it predates
   per-user ~/.gbp.conf [12].  I also filed Debian bug #501243 [13],
   since .gbp.conf is clearly a VCS file.

d) fso-frameworkd: binary-without-manpage usr/bin/cli-framework
   fso-frameworkd: binary-without-manpage usr/bin/frameworkd

   AFAIK they don't accept any option, thus writing a manpage should not
   be difficult.  However, this is an upstream bug.

3) fso-frameworkd: executable-not-elf-or-script
   ./usr/share/doc/fso-frameworkd/examples/ogsmd-execute-script-on-incoming-call.py

   This is clearly an upstream bug, since the script is missing the
   shebang.

Thx, bye,
Gismo / Luca

Footnotes: 
[1] http://git.debian.org/?p=pkg-fso/fso-frameworkd.git;a=commitdiff;h=8f6b1bf96759b73b98e5e210f825ce1318179cb0
    http://git.debian.org/?p=pkg-fso/fso-frameworkd.git;a=commitdiff;h=4f98b77542d89ccd16453904a74334a0b19d5856
[2] http://trac.freesmartphone.org/ticket/90
[3] http://git.debian.org/?p=pkg-fso/fso-frameworkd.git;a=commitdiff;h=f78af4c5dcf5e48a8b6465f3722f920fd8a38f95
[4] http://git.debian.org/?p=pkg-fso/fso-frameworkd.git;a=blob;f=framework/subsystems/ogsmd/gsm/channel.py;h=9274e5da2ac3cc71293b87bf48bc543d17b58bb6;hb=refs/heads/master
[5] copy the upstream file into
     /var/lib/python-support/python2.5/framework/subsystems/ogsmd/gsm/
[6] http://git.debian.org/?p=pkg-fso/fso-frameworkd.git;a=commitdiff;h=723b74a5db0a0ea6393c7a7b26f7dffa673f1121
    http://git.debian.org/?p=pkg-fso/fso-frameworkd.git;a=commitdiff;h=e9f68595d9cc6fc27809e121746597b1b13c3695
    http://git.debian.org/?p=pkg-fso/fso-frameworkd.git;a=commitdiff;h=472823a3a19e62a5d58bb05dcd720f76f267ab0a
[7] http://git.debian.org/?p=pkg-fso/fso-frameworkd.git;a=commitdiff;h=f120d5a6e90ce24cd51b984aa31d6ca7153bb828
[8] http://git.debian.org/?p=pkg-fso/fso-frameworkd.git;a=commitdiff;h=f120d5a6e90ce24cd51b984aa31d6ca7153bb828
[9] http://git.debian.org/?p=pkg-fso/fso-frameworkd.git;a=commitdiff;h=393773d6ea2fbb4855c29ba2b998cc0626dcf2bd
[10] http://trac.freesmartphone.org/ticket/143#comment:5
[11] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=495668
[12] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=500254
[13] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=501243
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 314 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20081005/e6035c09/attachment-0001.pgp