[pkg-fso-maint] install.sh typo in stage debian

[Steffen Moeller]

Hi Jos,

Joachim Breitner wrote:

> Am Samstag, den 28.02.2009, 12:01 +0100 schrieb Jos vd Snepscheut:
>> I think there is a typo in stage debian of install.sh.
>> Wget $CDEBOOTSTRAP_PACKAGE -0 /tmp/cdbootstrap.deb (cd /tmp: ar -x.........
>>
>> The ar should read TAR low cap (t is missing)
> 
> as a matter of fact, there is an ARchive program called ar. I presume
> it’s even oder than tar... but unless you know about how .deb files are
> made up, you most likely haven’t heard about it.
> 
>> Could you please correct this?
> 
> Well, as it would brake it, no. But thanks for the hint :-)
> 
> Or did you have programs with the installer? In that case, please paste
> any error messages and relevant log files.

indeed, Debian packages are "ar" archives. That command is correct.
The command extracts the tar archive which in turn should be untared under /.

>> and maybe an other idea could be to have a resume function, so that 
>> after exiting by an error the install process could be resumed with the 
>> (corrected phase i. e. after correcting the tar syntacts one could 
>> continue with: resume install.sh debian and than not only phase debian 
>> but all the next phases wold be installed)
>>
>> I hope you get my point.
> 
> I do. But I think it’s ok to have the users look in the welcome screen
> what phases would be run, and then run
> $ install.sh debian next_phase second_next_phase...
> This also gives more control over the flow.

I am with Joachim here. The "set -e" will let the script stop whenever there
was something unforseen. We'd need to add quite some code to check every
possible point of failure and give respective instructions. You probably don't really mean
that but think of some command like
	./install.sh --continue debian
or so. I don't mind that. If you have the code under your fingertips then please send a patch.

Many greetings

Steffen