[pkg-fso-maint] [PATCH] Disable frameworkd suspend-on-power-button in order not to conflict with zhone power-button feature

[Luca Capello]

Hi there!

On Mon, 27 Jul 2009 00:05:39 +0200, Lionel Elie Mamane wrote:
> --- a/common/etc/freesmartphone/oevents/rules.yaml
> +++ b/common/etc/freesmartphone/oevents/rules.yaml
> @@ -28,13 +28,21 @@
>      #
>      # Suspend Handling
>      #
> -    trigger: InputEvent()
> -    filters:
> -             - HasAttr(switch, "POWER")
> -             - HasAttr(event, "released")
> -             - HasAttr(duration, 0)
> -    actions: Suspend()
> --
> +#
> +# In the default Debian install, zhone is started; it reacts to the
> +# power button by presenting a menu allowing to suspend / shutdown /
> +# reboot / Lock screen / turn on Bluetooth/WiFi/GPS.

As you already know by now, Zhone does not react to power button, but
openmoko-panel-plugin does instead.  Thus your patch should be adapted
to reflect this...

Moreove, Git has a very strong policy about commit style:

    http://git.or.cz/gitwiki/CommitMessageConventions
    http://chistera.yi.org/~adeodato/blog/entries/2009/01/15/quality_of_commit_messages_in_git_upstream.html

> +# Frameworkd suspending on power-button conflicts with that and it is
> +# thus disabled by default. If you don't use zhone, you may want to
> +# reenable it. Just delete this comment and uncomment the following:

I strongly disagree on this patch: IMHO we should follow upstream
freesmartphone.org as much as we can, thus not disabling power button.

In case we want to do that anyway, well, the issue should be discussed
with upstream.  Since the freesmartphone.org distribution is now SHR,
how does SHR behaves in this case?

Thx, bye,
Gismo / Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fso-maint/attachments/20090728/2a5b9f62/attachment-0001.pgp>